jdk10 : simplify jexec build settings
    Baesken, Matthias 
    matthias.baesken at sap.com
       
    Thu Feb  9 11:36:43 UTC 2017
    
    
  
Hello ,  while adjusting the jspawnhelper build settings with 8174086, it has been noticed that the jexec build settings need some simplification as well.
The bug
https://bugs.openjdk.java.net/browse/JDK-8174242
has been created for this.
When looking into it,  I had some questions :
http://hg.openjdk.java.net/jdk10/jdk10/jdk/file/ae7afa9abe67/make/launcher/Launcher-java.base.gmk
The makefile  (make/launcher/Launcher-java.base.gmk )  handles Solaris 32bit,  but is this really  supported  in jdk 9 or 10  ( I think it was removed in 9 and only 64bit Solaris support remains ) ?
ifeq ($(OPENJDK_TARGET_OS), solaris)
  ifeq ($(OPENJDK_TARGET_CPU_BITS), 32)
    BUILD_JEXEC := 1
  endif
endif
ifeq ($(OPENJDK_TARGET_OS), linux)
  BUILD_JEXEC := 1
endif # OPENJDK_TARGET_OS
#
# jdk/make/java/jexec/Makefile
#
ifeq ($(BUILD_JEXEC), 1)
Then there is handling for macosx left , but the build is not enabled for macosx, does it still make sense to include the macosx handling (there is even a separate jexec.c for macosx) :
  ifeq ($(OPENJDK_TARGET_OS), windows)
  else ifeq ($(OPENJDK_TARGET_OS), macosx)
    BUILD_JEXEC_SRC := $(JDK_TOPDIR)/src/java.base/macosx/native/launcher
  else
    BUILD_JEXEC_SRC := $(JDK_TOPDIR)/src/java.base/unix/native/launcher
  endif
Should I remove  the solaris 32bit / macosx handling  for jexec  from   make/launcher/Launcher-java.base.gmk ?
Regards, Matthias
    
    
More information about the build-dev
mailing list