[9] RFR[L] 8174879: Rename jdk.vm.ci to jdk.internal.vm.ci

[Doug Simon]

> On 16 Feb 2017, at 19:30, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
> 
> Hi Doug,
> 
> Is it because of next change?:
> 
>   module jdk.internal.vm.ci {
> -      exports jdk.vm.ci.services;
> +      exports jdk.vm.ci.services to jdk.internal.vm.compiler;
> 
> But you said before that your version of graal has the same module name. Why you need --add-exports?

I am projecting ahead to the bug fix Mandy talks about in http://mail.openjdk.java.net/pipermail/graal-dev/2017-February/004889.html which means patching in an external version of Graal will no longer benefit from the qualified exports of JVMCI to jdk.vm.compiler.

-Doug

> On 2/16/17 2:01 AM, Doug Simon wrote:
>> Just to note here, this means an external version of Graal will now have to use --add-exports VM options to access JVMCI. Which is ok since additional VM options are required anyway to put an external Graal on the module path.
>> 
>> -Doug
>> 
>>> On 16 Feb 2017, at 08:54, Magnus Ihse Bursie <magnus.ihse.bursie at oracle.com> wrote:
>>> 
>>> On 2017-02-16 02:37, Vladimir Kozlov wrote:
>>>> https://bugs.openjdk.java.net/browse/JDK-8174879
>>>> 
>>>> jdk.vm.ci and jdk.vm.compiler are purely JVM internal modules that is only of interest to VM developers (and researchers), not general Java developers. It'd be appropriate for it to be an internal module and not to export any API.
>>>> 
>>>> Rename jdk.vm.ci and jdk.vm.compiler modules to jdk.internal.vm.ci and jdk.internal.vm.compiler. No packages renaming.
>>>> Exports jdk.vm.ci.services only to jdk.internal.vm.compiler.
>>>> 
>>>> Webrevs:
>>>> 
>>>> top: http://cr.openjdk.java.net/~kvn/8174879/webrev.top/
>>>> jdk: http://cr.openjdk.java.net/~kvn/8174879/webrev.jdk/
>>>> hotspot: http://cr.openjdk.java.net/~kvn/8174879/webrev.hs/
>>> 
>>> Looks good to me.
>>> 
>>> /Magnus
>>>> 
>>>> Tested with RBT.
>>>> 
>>>> Thanks,
>>>> Vladimir
>>> 
>>