RFR: JDK-8173107 Fix autoconf/spec.gmk mismatches

Erik Joelsson erik.joelsson at oracle.com
Fri Jan 20 13:28:24 UTC 2017


Looks good.

/Erik


On 2017-01-20 09:58, Magnus Ihse Bursie wrote:
> Over the course of jdk9 development, the variables in the configure 
> script exported using AC_SUBST, the replacement patterns in 
> spec.gmk.in and the usage of spec.gmk in the makefiles have diverged.
>
> Fixes:
>
> * Remove AC_SUBST for variables not exported or not used in make 
> files. (BOOT_JDK_BITS, ZERO_ARCHFLAG, ZERO_ARCHDEF, INCLUDE_DTRACE, 
> OPENJDK_*_OS_BUNDLE, OPENJDK_*_CPU_BUNDLE, LP64, ENABLE_JFR)
> * Include missing exports in spec.gmk.in (JDK_ARCH_ABI_PROP_NAME)
> * Make sure we always explicitly use AC_SUBST for exported variables 
> (PNG_CFLAGS, PNG_LIBS, LCMS_CFLAGS, LCMS_LIBS)
> * Only use the pattern AC_SUBST(VARIABLE), to make sure the VARIABLE 
> is accessible in configure as well as make.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8173107
> WebRev: 
> http://cr.openjdk.java.net/~ihse/JDK-8173107-fix-spec-gmk-mismatches/webrev.01
>
> /Magnus
>




More information about the build-dev mailing list