RFR: JDK-8081694 Remove DISABLED_WARNINGS_gcc for libsctp

[Chris Hegarty]

On 30/01/17 08:08, Magnus Ihse Bursie wrote:
> On 2017-01-26 15:28, Chris Hegarty wrote:
>> I’m not sure of the latest status of warnings in the build, but
>> just to say, libstcp was always built with 0 warnings being
>> emitted ( the JNI code has unused this/class parameters
>> that cannot be removed ). If you remove this suppression
>> won’t the compilation of code from libsctp now produce a
>> warning for these cannot-be-removed unused parameters?
>> Misleading development engineers trying to clean up
>> warnings.
>
> We have a global -Wno-unused-parameter for gcc. This is a common
> scenario, of functions following a formal pattern even if they don't
> need all parameters, so it does not really make sense to ever have it
> enabled.

In which case, I happy with this change.

-Chris.

> /Magnus
>
>>
>> -Chris.
>>
>>> On 26 Jan 2017, at 13:54, Magnus Ihse Bursie <magnus.ihse.bursie at oracle.com> wrote:
>>>
>>> When fixing JDK-8081616 <https://bugs.openjdk.java.net/browse/JDK-8081616>, it turned out that
>>> DISABLED_WARNINGS_gcc := unused-parameter
>>> seemed to be needed for libsctp in make/lib/Lib-jdk.sctp.gmk.
>>>
>>> This is not be needed anymore (and possibly never was).
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8081694
>>> Patch inline:
>>> diff --git a/make/lib/Lib-jdk.sctp.gmk b/make/lib/Lib-jdk.sctp.gmk
>>> --- a/make/lib/Lib-jdk.sctp.gmk
>>> +++ b/make/lib/Lib-jdk.sctp.gmk
>>> @@ -45,7 +45,6 @@
>>>             $(LIBJAVA_HEADER_FLAGS) \
>>>             -I$(SUPPORT_OUTPUTDIR)/headers/jdk.sctp \
>>>             -I$(SUPPORT_OUTPUTDIR)/headers/java.base, \
>>> -        DISABLED_WARNINGS_gcc := unused-parameter, \
>>>         MAPFILE := $(JDK_TOPDIR)/make/mapfiles/libsctp/mapfile-vers, \
>>>         LDFLAGS := $(LDFLAGS_JDKLIB) \
>>>             $(call SET_SHARED_LIBRARY_ORIGIN), \
>>>
>