Review Request: JDK-8173608: Separate JDK management agent from java.management module
Erik Joelsson
erik.joelsson at oracle.com
Tue Jan 31 16:44:41 UTC 2017
On 2017-01-31 17:04, Mandy Chung wrote:
>
>> On Jan 31, 2017, at 12:20 AM, Erik Joelsson <erik.joelsson at oracle.com> wrote:
>>
>> Are all the libraries added to LIBS still needed for this breakout lib? And are all of them still needed for libmanagement.so from which this was split out?
>>
> Good catch. I updated Lib-jdk.management.agent.gmk with:
>
> LIBS := $(JDKLIB_LIBS), \
> LIBS_windows := $(WIN_JAVA_LIB) advapi32.lib, \
>
> We should examine the native code in both java.management and jdk.management and I suspect the makefile would need cleanup. Are you okay to follow up the makefile as a separate issue? As the native code in jdk.management.agent, it can be converted to use NIO 2 and hope to get to it in a near future so that jdk.management.agent will have java code only.
The adjustment proposed here is fine with me.
/Erik
More information about the build-dev
mailing list