Review Request: JDK-8173608: Separate JDK management agent from java.management module

[David Holmes]

On 1/02/2017 12:57 AM, Mandy Chung wrote:
>
>> On Jan 30, 2017, at 11:00 PM, David Holmes <david.holmes at oracle.com> wrote:
>>
>> Hi Mandy,
>>
>> On 31/01/2017 9:48 AM, Mandy Chung wrote:
>>> Webrev at:
>>> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8173608/webrev.00/index.html
>>
>> This all seems okay.
>>
>
> Thanks for the review.
>
>> But we have quite a few hotspot tests that include:
>>
>> @modules java.management/sun.management
>>
>
> Only 4 classes in the java.management/sun.management are moved to jdk.management.agent/jdk.internal.agent.
>
> From my grep on hotspot tests, no test uses those renamed classes.

Ah I see. Thanks for clarifying.

David

> Mandy
>
>> that would seem to need updating as well.
>>
>> Thanks,
>> David
>> -----
>>
>>> Mandy
>>>
>>>> On Jan 30, 2017, at 3:42 PM, Mandy Chung <mandy.chung at oracle.com> wrote:
>>>>
>>>> java.management is the module for JMX and JMX remote API and
>>>> java.lang.management. JDK management agent provides the JDK-specific
>>>> out-of-the-box monitoring and management support and it’s cleaner
>>>> for it to live in its own module.  It is proposed to move it
>>>> to a new module named `jdk.management.agent`.
>>>>
>>>> This change involves:
>>>> 1) renaming of sun.management.Agent along with 3 other classes
>>>> in sun.management package to jdk.internal.agent package
>>>>
>>>> 2) move sun.management.resources to jdk.internal.agent.resources
>>>>
>>>> 3) move sun.management.jmxremote and sun.management.jdp packages
>>>> to jdk.management.agent module
>>>>
>>>> 4) move the configuration files under conf/management
>>>>
>>>> 5) sun/management/jmxremote/ConnectorBootstrap.java is updated
>>>> to replace the use of the ClassLogger API with System.Logger.
>>>>
>>>> 6) change hotspot VM to add `jdk.management.agent` when
>>>> -Dcom.sun.management.* system property is set as well as
>>>> the Agent class rename
>>>>
>>>> Daniel is working on JDK-8173607 [1] that conflicts with this
>>>> patch and require merges/coordination.
>>>>
>>>> We propose to integrate these changes to jdk9/dev unless
>>>> there is any objection concerning that this trivial hotspot change
>>>> might cause any issue.  I have submitted a RBT on hotspot_runtime
>>>> and hotspot_serviceability in addition to PIT test runs.
>>>>
>>>> thanks
>>>> Mandy
>>>> [1] https://bugs.openjdk.java.net/browse/JDK-8173607
>>>
>