jdk10 : UseSharedSpaces flag and INCLUDE_CDS macro

[Baesken, Matthias]

Hello, when looking into CDS related build options,  I noticed  that most  code-parts  that are executed only when UseSharedSpaces is set,
  are guarded by  the compile-time macro    INCLUDE_CDS   to support  switching off   compilation of this coding
  when  CDS is disabled at compile time  :


See  hotspot/make/lib/JvmFeatures.gmk  :

ifneq ($(call check-jvm-feature, cds), true)
  JVM_CFLAGS_FEATURES += -DINCLUDE_CDS=0



However some places miss the compile-time guarding ( #if INCLUDE_CDS  ....) for example in


share/vm/prims/jvmtiRedefineClasses.cpp
share/vm/memory/universe.cpp

(also some other places)


Should I prepare a change and add the compile-time guard at the places where missing as well ?

Best regards, Matthias