JDK 10 Review Request for JDK-8176583: Move currency data to /lib

Nishit Jain nishit.jain at oracle.com
Mon Jul 17 04:00:52 UTC 2017


Hi Roger,

This change is put on hold. After some internal discussion, no strong 
reason came up to move it out of java.base, unless currency data 
requires frequent updates and that too should be allowed through a 
service provider mechanism. Please refer the comments section of 
JDK-8176583.

Regards,
Nishit Jain
On 14-07-2017 23:16, Roger Riggs wrote:
> Hi Nishit,
>
> I haven't seen any comments in the past month...
>
> From the code perspective, this looks ok.
>
> It should have a build Reviewer too.
>
> Thanks, Roger
>
> On 6/13/2017 12:57 PM, Nishit Jain wrote:
>> Hi,
>>
>> Please review the fix for JDK-8176583
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8176583
>> Webrev: http://cr.openjdk.java.net/~nishjain/8176583/webrev.02/
>>
>> Fix: Relocated currency.data from java.base module 
>> (/java.base/java/util/currency.data) to /lib directory
>>
>> Review mail thread of JDK-8176583 at i18n-dev: 
>> http://mail.openjdk.java.net/pipermail/i18n-dev/2017-June/002307.html
>>
>> Regards,
>> Nishit Jain
>




More information about the build-dev mailing list