RFR: JDK-8179438: Incremental builds broken on Windows

Magnus Ihse Bursie magnus.ihse.bursie at oracle.com
Wed May 3 07:02:08 UTC 2017


On 2017-05-03 00:00, Erik Joelsson wrote:
> This is the same fix as I already din in JDK 10 in JDK-8179079. The 
> problem was annoying enough that we need it fixed in 9 too. The patch 
> is exactly the same.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8179438
>
> diff -r 143d4c87bc1e make/common/NativeCompilation.gmk
> --- a/make/common/NativeCompilation.gmk Fri Apr 28 15:40:49 2017 +0200
> +++ b/make/common/NativeCompilation.gmk Tue May 02 23:54:24 2017 +0200
> @@ -165,6 +165,7 @@
>  WINDOWS_SHOWINCLUDE_SED_PATTERN := \
>      -e '/^Note: including file:/!d' \
>      -e 's|Note: including file: *||' \
> +    -e 's|\r||g' \
>      -e 's|\\|/|g' \
>      -e 's|^\([a-zA-Z]\):|$(UNIX_PATH_PREFIX)/\1|g' \
>      -e '\|$(TOPDIR)|I !d' \
>

Looks good to me.

/Magnus



More information about the build-dev mailing list