RFR: XS: URGENT: JDK-8180129, , Bundles.gmk:181: *** unterminated call to function 'filter-out': missing ')'

Erik Joelsson erik.joelsson at oracle.com
Wed May 10 22:07:05 UTC 2017


Looks good. Thanks for fixing this!

/Erik


On 2017-05-10 15:06, Tim Bell wrote:
> A fix for packaging changes in the closed files missed one line
> continuation in an open file, and without this all builds fail:
>
> % hg diff
> diff --git a/make/Bundles.gmk b/make/Bundles.gmk
> --- a/make/Bundles.gmk
> +++ b/make/Bundles.gmk
> @@ -183,7 +183,7 @@
>            $(JDK_SYMBOLS_EXCLUDE_PATTERN) \
>            $(JDK_EXTRA_EXCLUDES) \
>            $(SYMBOLS_EXCLUDE_PATTERN) \
> -          $(JDK_IMAGE_HOMEDIR)/demo/%
> +          $(JDK_IMAGE_HOMEDIR)/demo/% \
>            , \
>            $(ALL_JDK_FILES) \
>        )
>
> Already reviewed in person by erikj.  I am sending to the open build 
> list to complete the loop.
>
> Thanks in advance-
>
> Tim




More information about the build-dev mailing list