RFR: 8179915: Update extLink taglet to allow not linking the description

Kumar Srinivasan kumar.x.srinivasan at oracle.com
Thu May 11 20:51:03 UTC 2017


Hi,

Changes in this webrev:
* inverted the logic as you suggested
* some doc comment changes to reflect the change

http://cr.openjdk.java.net/~ksrini/8179915/webrev.1/

Thanks
Kumar

On 5/10/2017 7:19 PM, David Holmes wrote:
> On 11/05/2017 3:18 AM, Kumar Srinivasan wrote:
>>
>> On 5/10/2017 9:51 AM, Erik Joelsson wrote:
>>> Should this be set on the javadoc command line somewhere or am I
>>> missing something?
>>
>> Yes, one would have to set this prop, via the build system, when
>> performing a non-oracle build.
>
> Shouldn't that be inverted then - given there is only 1 Oracle build 
> and potentially innumerable non-Oracle builds? The default should be 
> to not link unless the property is set.
>
> Thanks,
> David
>
>> Kumar
>>
>>>
>>> /Erik
>>>
>>>
>>> On 2017-05-10 09:42, Kumar Srinivasan wrote:
>>>> Hi,
>>>>
>>>> Please review fix for the custom taglet to allow openjdk builds, in
>>>> which case
>>>> the property "build.tools.taglet.ExtLink.NO_LINK" must be set to
>>>> inhibit server
>>>> side lookups.
>>>>
>>>> Thanks
>>>> Kumar
>>>>
>>>> Webrev: http://cr.openjdk.java.net/~ksrini/8179915/webrev.0
>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8179915
>>>
>>




More information about the build-dev mailing list