[PATCH]: linux-sparc build fixes
David Holmes
david.holmes at oracle.com
Mon May 29 02:17:13 UTC 2017
Hi Adrian,
cc'ing hotspot-dev and bcc'ing build-dev as these are not issues with
the build files, but hotspot sources.
First, than you for taking the time and effort to contribute to OpenJDK.
However ...
The status of linux-sparc as a port in OpenJDK 9 (or 8u) is unclear. As
you have found those bits have bit-rotted as it is not a supported
Oracle JDK platform, and no-one else seems to have cared until now. Your
patches may be acceptable, but we have no way to validate them. And the
very next push may break things again. Or indeed once the hotspot issues
are resolved you may find issues on the JDK library side. The process to
get them into JDK 9 now is somewhat more difficult given where we are in
the JDK 9 release. But without a commitment from some part of the
community to maintain this port it may be better as something that is
maintained downstream.
It would be interesting to hear from the Hotspot group leads on this.
Thanks,
David
On 27/05/2017 10:28 PM, John Paul Adrian Glaubitz wrote:
> Hello!
>
> openjdk-9 currently fails to build from source on Debian/sparc64 [1].
>
> One of the reasons it fails is because of a misnamed header filename:
>
> In file included from /<<PKGBUILDDIR>>/src/hotspot/src/share/vm/memory/allocation.inline.hpp:28:0,
> from /<<PKGBUILDDIR>>/src/hotspot/src/share/vm/utilities/array.hpp:29,
> from /<<PKGBUILDDIR>>/src/hotspot/src/share/vm/memory/universe.hpp:29,
> from /<<PKGBUILDDIR>>/src/hotspot/src/share/vm/code/oopRecorder.hpp:28,
> from /<<PKGBUILDDIR>>/src/hotspot/src/share/vm/asm/codeBuffer.hpp:28,
> from /<<PKGBUILDDIR>>/src/hotspot/src/share/vm/asm/assembler.hpp:28,
> from /<<PKGBUILDDIR>>/src/hotspot/src/share/vm/asm/macroAssembler.hpp:28,
> from /<<PKGBUILDDIR>>/src/hotspot/src/cpu/sparc/vm/nativeInst_sparc.hpp:28,
> from /<<PKGBUILDDIR>>/src/hotspot/src/share/vm/code/nativeInst.hpp:30,
> from ad_sparc.hpp:32,
> from ad_sparc_misc.cpp:28:
> /<<PKGBUILDDIR>>/src/hotspot/src/share/vm/runtime/atomic.hpp:126:31: fatal error: atomic_linux_sparc.hpp: No such file or directory
> #include OS_CPU_HEADER(atomic)
>
> While fixing this, I also discovered some other problems with the build on Debian/sparc64.
>
> I'm attaching a set of three patches which address all the issues I have discovered with
> openjdk-9 on Debian/sparc64 so far. They should apply to all builds on 64-bit Linux SPARC.
>
> Please note, this is my first attempt ever trying to get patches into OpenJDK, so I will
> definitely need a little guidance. I have already asked in the #openjdk channel and after
> signing the OCA and sending it in, I was told to post my patches here. So here they are :).
>
> Let's hope I can get them into the proper shape for getting them merged.
>
> All patches are:
>
> Signed-off by: John Paul Adrian Glaubitz <glaubitz at physik.fu-berlin.de>
>
> Thanks,
> Adrian
>
>> [1] https://buildd.debian.org/status/fetch.php?pkg=openjdk-9&arch=sparc64&ver=9%7Eb170-2&stamp=1495173966&raw=0
>
More information about the build-dev
mailing list