RFR: JDK-8191203 Remove duplicated jimage.hpp

[Tim Bell]

Magnus:

Looks good to me as well.

Tim

On 11/21/17 06:11, Jim Laskey (Oracle) wrote:
> The file was moved from hs to the jdk to simplify the API, not sure why it’s still there.  A bulk merge issue maybe.  I don’t recall clearly but I think the BSD license was a request from that other big company.
>
> Cheers,
>
> — Jim
>
>> On Nov 21, 2017, at 10:00 AM, Magnus Ihse Bursie <magnus.ihse.bursie at oracle.com> wrote:
>>
>> On 2017-11-21 12:44, David Holmes wrote:
>>> Hi Magnus,
>>>
>>> This seems fine to me.
>>>
>>> Do you know what the story is with the copyright header?
>> No, I don't. It was introduced in JDK-8149776, which has just a brief rationale:
>> "Allow the jimage native code to be more easily re-used in JVM implementations which cannot accept code under the GPL." I do not know what prompted this.
>>
>> It seems reasonable to keep the more liberaly licensed version, though. (Which happens to coincide with the JDK version).
>>
>> /Magnus
>>>
>>> Thanks,
>>> David
>>>
>>> On 21/11/2017 9:13 PM, Magnus Ihse Bursie wrote:
>>>> I ran a duplicate name check on the source base. Then I discovered that there is a jimage.hpp in both src/hotspot/share/classfile/jimage.hpp and src/java.base/share/native/libjimage/jimage.hpp. They are identical (apart from copyright headers), and once again, we shouldn't have both. David Holmes suggested removing the hotspot version, so this I've done.
>>>>
>>>> I intend to push this to jdk/hs.
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8191203
>>>> WebRev: http://cr.openjdk.java.net/~ihse/JDK-8191203-remove-duplicated-jimage-hpp/webrev.01
>>>>
>>>> /Magnus