RFR: JDK-8191820 run-test jtreg test selection and component calculation broken since consolidation

Magnus Ihse Bursie magnus.ihse.bursie at oracle.com
Fri Nov 24 08:23:01 UTC 2017


On 2017-11-23 17:17, Erik Joelsson wrote:
> Looks good, except for the indentation of the value for $1_COMPONENT.
Oops. Fixed.
> It's really a shame that you can't add comments inside the big blocks 
> of functional logic. It sure would help in understanding what each sub 
> block was trying to achieve.
Yes, it is. :( I spent some time trying to understand the previous code. 
Even though it was written by myself... for less then a year ago. :-&

I tried to tackle this somewhat by breaking out functionality in 
functions with descriptive names.

/Magnus
>
> /Erik
>
>
> On 2017-11-23 06:20, Magnus Ihse Bursie wrote:
>> The test selection and component calculation for jtreg tests have 
>> been broken since the consolidated and restructured forest.
>>
>> This fix will restore component calculation (which solves issues with 
>> incorrect component-specific settings, such as nativepath). It also 
>> allows for a more flexible test selection mechanism, better suited to 
>> the new test structure, while at the same time cleaning up at least a 
>> bit of the almost incomprehensible make function.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8191820
>> WebRev: 
>> http://cr.openjdk.java.net/~ihse/JDK-8191820-fix-jtreg-test-selection/webrev.01
>>
>> /Magnus
>




More information about the build-dev mailing list