RFR: JDK-8179555 make run-test should always use a fresh, clean JTwork directory

Tim Bell tim.bell at oracle.com
Mon Nov 27 17:19:18 UTC 2017


Magnus:

>    "...always run with a fresh, clean JTwork directory..."

I couldn't agree more.  Looks good to me as well.

Tim

On 11/27/17 08:42, Erik Joelsson wrote:
> Looks good.
>
> /Erik
>
>
> On 2017-11-24 02:23, Magnus Ihse Bursie wrote:
>> When running jtreg tests, make run-test should always run with a
>> fresh, clean JTwork directory in order to avoid issues with code not
>> being recompiled.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8179555
>> Patch inline:
>> diff --git a/make/RunTests.gmk b/make/RunTests.gmk
>> --- a/make/RunTests.gmk
>> +++ b/make/RunTests.gmk
>> @@ -407,7 +407,10 @@
>>      $1_JTREG_BASIC_OPTIONS += -cpa:$$(JIB_JAR)
>>    endif
>>
>> -  run-test-$1:
>> +  clean-workdir-$1:
>> +       $$(RM) -r $$($1_TEST_SUPPORT_DIR)
>> +
>> +  run-test-$1: clean-workdir-$1
>>         $$(call LogWarn)
>>         $$(call LogWarn, Running test '$$($1_TEST)')
>>         $$(call MakeDir, $$($1_TEST_RESULTS_DIR) $$($1_TEST_SUPPORT_DIR))
>>
>> /Magnus
>>
>




More information about the build-dev mailing list