RFR: JDK-8188768 Fix interaction between make and autoconf after consolidation

[Erik Joelsson]

Hello David,


On 2017-10-04 23:22, David Holmes wrote:
> Hi Magnus,
>
> On 4/10/2017 10:40 PM, Magnus Ihse Bursie wrote:
>> Since the forest consolidation, multiple "paper-cut" issues have 
>> appeared.
>>
>> This patch will deal with the following issues:
>> * Changes in autoconf files will no longer cause make to require a 
>> reconfigure.
>> * "make reconfigure" was broken when closed sources were present
>> * The new relationship between open and closed code allows for a more 
>> streamlined support for custom extensions in the open code.
>
> I'm a little confused by the changes. It seems now that 
> CUSTOM_CONFIG_DIR must always be set when calling autogen.sh, to do 
> any custom configure generation. So where previously I would run "bash 
> common/autoconf/autogen/sh" and it would handle open and custom, now 
> it will only handle open unless CUSTOM_CONFIG_DIR is set. And the 
> expectation is now that I would invoke the custom autogen.sh to also 
> handle the open case - is that right?
>
With our new model with closed encapsulating open, the biggest 
difference in the interaction is that we now have two different entry 
points, where before we only had one. You either run the open configure 
script/makefile, or you run the wrapper from the closed repository. So 
instead of open having to assume where the custom directories are, we 
only provide hooks to provide them through these new variables. Then 
it's the responsibility of the closed wrapping script/makefile to set 
those variables.

So yes, when dealing with an OracleJDK build, you are now expected to 
run the closed wrappers of configure/Makefile/autogen.sh.

/Erik
> Thanks,
> David
>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8188768
>> WebRev: 
>> http://cr.openjdk.java.net/~ihse/JDK-8188768-fix-make-and-autoconf-interaction/webrev.01 
>>
>>
>> /Magnus