RFR: JDK-8189222 Remove make/corba/Makefile

Magnus Ihse Bursie magnus.ihse.bursie at oracle.com
Thu Oct 12 11:40:02 UTC 2017


On 2017-10-12 13:37, Alan Bateman wrote:
>
>
> On 12/10/2017 12:15, Magnus Ihse Bursie wrote:
>> We should remove make/corba/Makefile. This should have been done long 
>> time ago by JDK-8076060.
>>
>> "Patch":
>>
>> $ hg st
>> R make/corba/Makefile
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8189222
>>
> Looks okay to me.
>
> One thing to keep in mind is that the java.corba module is deprecated 
> for removal and we will be proposing a JEP to remove it, hopefully to 
> target the 18.9 release assuming all the work is done in time. Just 
> mentioning it to avoid spending time on make files that we expect will 
> go away.
Agree. This was more an accidental discovery and "wtf is it still doing 
here"?

In a somewhat related note, however, I would like to spend some time to 
reorganize the new unified "make" directory. Currently it's the old 
$TOP/make and $TOP/jdk/make laid on top of each other, with $REPO/make 
in make/$REPO for all the other old repos.

And not that the individual make directories were well organized before, 
either...

/Magnus

>
> -Alan
>




More information about the build-dev mailing list