RFR: JDK-8189229 Remove references to $(TOPDIR)/src/*/$(MODULE)
Erik Joelsson
erik.joelsson at oracle.com
Fri Oct 13 11:07:22 UTC 2017
Looks good.
/Erik
On 2017-10-13 11:31, Magnus Ihse Bursie wrote:
> Here's an updated webrev:
>
> http://cr.openjdk.java.net/~ihse/JDK-8189229-fix-superfluous-FillCacheFind-paths/webrev.02
>
>
> /Magnus
>
>
> On 2017-10-12 17:00, Magnus Ihse Bursie wrote:
>> Erik commented off-line that this code was intended to include closed
>> source code. It was indeed correct prior to the consolidation, but
>> has not been working since. The code is a performance optimization,
>> and not about correctness, that's why it has not been detected.
>>
>> I'll come back with an updated review that will restore the behavior
>> with respect to closed sources.
>>
>> /Magnus
>>
>> On 2017-10-12 16:38, Magnus Ihse Bursie wrote:
>>> When creating the consolidated forest, old paths were rewritten
>>> automatically using pattern matching. Unfortunately, this resulted
>>> in incorrect paths in some places.
>>>
>>> Specifically, we do not need to look for source code in
>>> $(TOPDIR)/src/*/$(MODULE).
>>>
>>> (Actually, some code history digging later it turns out that, while
>>> this was modified during the consolidation, the code was incorrect
>>> even before.)
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8189229
>>> WebRev:
>>> http://cr.openjdk.java.net/~ihse/JDK-8189229-fix-superfluous-FillCacheFind-paths/webrev.01
>>>
>>> /Magnus
>>
>
More information about the build-dev
mailing list