RFR: JDK-8189263 Introduce CUSTOM_ROOT

David Holmes david.holmes at oracle.com
Fri Oct 13 13:08:46 UTC 2017


Hi Magnus,

I find this all very confusing - we have a number of CUSTOM_* variables 
now and I would expect they to be closely tied together. Also unclear if 
TOPDIR is really the top-dir or the top of the "open" repo? If really 
the top then aren't TOPDIR and CUSTOM_ROOT the same ?? Or are we 
allowing the custom and regular parts to exist isolated in the filesystem ??

Thanks,
David

On 13/10/2017 8:11 PM, Magnus Ihse Bursie wrote:
> To support the use case where the OpenJDK repository is included as part 
> of a custom project, this patch introduces the concept of a "custom 
> root", which plays the role of $TOPDIR in some circumstances. It is the 
> responsibility of any custom code to keep this value and propagate it 
> where needed.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8189263
> WebRev: 
> http://cr.openjdk.java.net/~ihse/JDK-8189263-introduce-CUSTOM_ROOT/webrev.01 
> 
> 
> /Magnus



More information about the build-dev mailing list