RFR: JDK-8189434: SetupCopyFiles does not handle files with $ in them

Magnus Ihse Bursie magnus.ihse.bursie at oracle.com
Tue Oct 17 13:18:43 UTC 2017


On 2017-10-17 14:11, Erik Joelsson wrote:
> The fix in JDK-8189324 wasn't quite complete. The whole SetupCopyFiles 
> macro still needs to be adjusted to properly handle files with $ in 
> them. In the previously known two locations where this was an issue, 
> we currently have explicit calls to DoubleDollar. Now we have a new 
> such location in MacBundles.gmk, but without the DoubleDollar call. 
> This patch fixes this by putting the necessary DoubleDollar calls in 
> SetupCopyFiles and removing it from the caller locations.
>
> Webrev: http://cr.openjdk.java.net/~erikj/8189434/webrev.01/
Typo: "wrap" is spelled with just one p.

Otherwise, looks good.

/Magnus

>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8189434
>
> /Erik
>




More information about the build-dev mailing list