RFR: JDK-8189607 Remove duplicated jvmticmlr.h
Erik Joelsson
erik.joelsson at oracle.com
Wed Oct 18 08:26:06 UTC 2017
On 2017-10-18 10:04, Magnus Ihse Bursie wrote:
> The file jvmticmlr.h is stored twice in the repo, both in hotspot and
> in java.base. They are both identical, and only the java.base version
> is included in the final product. This might arguably have been useful
> in a pre-consolidated world, but makes absolutely no sense now.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8189607
> WebRev:
> http://cr.openjdk.java.net/~ihse/JDK-8189607-remove-duplicated-jvmticmlr/webrev.01
>
The question is, which file location makes the most sense. I think your
pick of java.base/share/native/include probably makes more sense as that
makes it much clearer that this is an exported header file.
Looks good to me.
/Erik
More information about the build-dev
mailing list