8189619: [aix, but changes generated-configure.sh] OpenJDK local disk check not working on AIX

Erik Joelsson erik.joelsson at oracle.com
Fri Oct 20 08:50:01 UTC 2017


Hello Thomas,

This looks good and I can sponsor it.

/Erik


On 2017-10-20 10:28, Thomas Stüfe wrote:
> Hi guys,
>
> if you have time, could I please have a review, this is really quite minor.
> I tested the resulting configure.sh on AIX, various Linuxes and Windows.
>
> Thank you!
>
> ..Thomas
>
> On Wed, Oct 18, 2017 at 5:45 PM, Thomas Stüfe <thomas.stuefe at gmail.com>
> wrote:
>
>> Hi all,
>>
>> May I have a review please for this tiny fix. Fixes the warning checking
>> if we build on a local disk.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8189619
>> Webrev: http://cr.openjdk.java.net/~stuefe/webrevs/
>> 8189619-openjdk-local-disk-check-broken-on-aix/webrev.00/webrev/
>>
>> Basically, df -l does not work and has to be substituted with df -T local.
>> Thanks to Stewart X Addison from the AdoptOpenJDK project for figuring this
>> out.
>>
>> I checked the build on linux and AIX, the latter with newer and older AIX
>> versions. At least on newer AIX versions the local build check works
>> correctly. On older versions we still get a misleading warning. There, we
>> may continue to ignore it or just switch it off if it is too annoying.
>>
>> Thank you,
>>
>> Kind Regards, Thomas
>>
>>




More information about the build-dev mailing list