RFR: JDK-8188090 Running tests from make causes spurious mercurial changes

Maurizio Cimadamore maurizio.cimadamore at oracle.com
Thu Sep 28 08:49:36 UTC 2017


Hi,
this fixes the problem of the build changing permissions on some library 
files when executing tests [1, 2].

The issue is that a relative path in TestCommon is bogus - jdk tests are 
now executed in the folder test/jdk, so there's no longer hg repo under ../

Patch inline below:

diff -r 355349babaf4 test/TestCommon.gmk
--- a/test/TestCommon.gmk    Wed Sep 27 16:47:07 2017 -0700
+++ b/test/TestCommon.gmk    Thu Sep 28 09:44:09 2017 +0100
@@ -273,7 +273,7 @@
  prep:
      @$(MKDIR) -p $(ABS_TEST_OUTPUT_DIR)
      @$(MKDIR) -p `$(DIRNAME) $(ARCHIVE_BUNDLE)`
-    @if [ ! -d $(TEST_ROOT)/../.hg ] ; 
then                                   \
+    @if [ ! -d $(TEST_ROOT)/../../.hg ] ; 
then                                   \
        $(FIND) $(TEST_ROOT) \( -name \*.dll -o -name \*.DLL -o -name 
\*.so \)  \
              -exec $(CHMOD) a+rx {} \; 
;                                       \
      fi


Cheers
Maurizio


[1] - 
http://mail.openjdk.java.net/pipermail/build-dev/2017-September/019796.html
[2] - https://bugs.openjdk.java.net/browse/JDK-8188090



More information about the build-dev mailing list