RFR [XS]: 8208744: remove unneeded -DUSE_MMAP settings for JDK native libs builds -was : RE: unneeded -DUSE_MMAP in JDK native libs builds

Martin Buchholz martinrb at google.com
Fri Aug 3 14:14:17 UTC 2018


Looks good to me.

On Fri, Aug 3, 2018 at 5:58 AM, Alan Bateman <Alan.Bateman at oracle.com>
wrote:

>
>
> On 03/08/2018 00:21, David Holmes wrote:
>
>> On 3/08/2018 4:59 PM, Baesken, Matthias wrote:
>>
>>> Thank  you  David ,  can the change be pushed ,  or do I need a second
>>> review for an XS change  ?
>>> (any way a second review would be good 😊 )
>>>
>>
>> Need a review from official build team member :)
>>
> I'm not in the build group but just to confirm that USE_MMAP is specific
> to libzip and dates back to when the entire zip file (not just the CEN) was
> memory mapped. I don't know how it got into make file to build libjdwp or
> libdt_socket. So the change looks right to me too.
>
> -Alan.
>



More information about the build-dev mailing list