how to install OpenJDK stuff for packaging - DESTDIR support

[Magnus Ihse Bursie]

On 2018-08-22 17:13, Petr Sumbera wrote:
> Hi all,
>
> I'm now able to build both OpenJDK 10 and 11 (thanks to all who helped 
> me!). Now what is the correct way to install it for packaging? For now 
> I use following patch (see below). But I wonder how should this be 
> done properly.
Hi Petr,

The code path you've found out has not been tested since the early days 
of the current (then "brand new") build system. I've actually been 
thinking from time to time that we should remove it, since it's not 
ordinarily used.

But if you see a point in keeping it, I'm happy to accept patches! :)

Does the installation work fine with the patch below?

/Magnus

>
> Thanks,
>
> Petr
>
> --- jdk/make/Install.gmk
> +++ jdk/make/Install.gmk
> @@ -35,9 +35,9 @@
>  install:
>         echo Installing jdk image into 
> $(INSTALL_PREFIX)/jvm/$(INSTALLDIR)
>         echo and creating $(words $(BINARIES)) links from 
> $(INSTALL_PREFIX)/bin into the jdk.
> -       $(MKDIR) -p $(INSTALL_PREFIX)/jvm/$(INSTALLDIR)
> -       $(RM) -r $(INSTALL_PREFIX)/jvm/$(INSTALLDIR)/*
> -       $(CP) -rp $(JDK_IMAGE_DIR)/* $(INSTALL_PREFIX)/jvm/$(INSTALLDIR)
> -       $(MKDIR) -p $(INSTALL_PREFIX)/bin
> -       $(RM) $(addprefix $(INSTALL_PREFIX)/bin/, $(BINARIES))
> -       $(foreach b, $(BINARIES), $(LN) -s 
> $(INSTALL_PREFIX)/jvm/$(INSTALLDIR)/bin/$b $(INSTALL_PREFIX)/bin/$b 
> &&) true
> +       $(MKDIR) -p $(DESTDIR)$(INSTALL_PREFIX)/jvm/$(INSTALLDIR)
> +       $(RM) -r  $(DESTDIR)$(INSTALL_PREFIX)/jvm/$(INSTALLDIR)/*
> +       $(CP) -rp  $(JDK_IMAGE_DIR)/* 
> $(DESTDIR)$(INSTALL_PREFIX)/jvm/$(INSTALLDIR)
> +       $(MKDIR) -p  $(DESTDIR)$(INSTALL_PREFIX)/bin
> +       $(RM) $(addprefix  $(DESTDIR)$(INSTALL_PREFIX)/bin/, $(BINARIES))
> +       $(foreach b, $(BINARIES), $(LN) -s 
> $(INSTALL_PREFIX)/jvm/$(INSTALLDIR)/bin/$b 
> $(DESTDIR)$(INSTALL_PREFIX)/bin/$b &&) true