RFR : 8210205 : build fails on AIX in hotspot cpp tests (for example getstacktr001.cpp)

[Baesken, Matthias]

Thanks ,  can I have a second review please ?

Best regards, Matthias

From: Lindenmaier, Goetz
Sent: Donnerstag, 30. August 2018 14:17
To: Baesken, Matthias <matthias.baesken at sap.com>; 'hotspot-dev at openjdk.java.net' <hotspot-dev at openjdk.java.net>; 'build-dev at openjdk.java.net' <build-dev at openjdk.java.net>
Cc: Doerr, Martin <martin.doerr at sap.com>
Subject: RE: RFR : 8210205 : build fails on AIX in hotspot cpp tests (for example getstacktr001.cpp)

Hi Matthias,

Aix is a nuisance.  Thanks for fixing this.
Looks good.

As this is a build fix, and only changes tests, I think you don't need
to follow the 24h rule, i.e., you can push it sooner.

Best regards,
  Goetz.

From: Baesken, Matthias
Sent: Donnerstag, 30. August 2018 13:21
To: 'hotspot-dev at openjdk.java.net' <hotspot-dev at openjdk.java.net<mailto:hotspot-dev at openjdk.java.net>>; 'build-dev at openjdk.java.net' <build-dev at openjdk.java.net<mailto:build-dev at openjdk.java.net>>
Cc: Lindenmaier, Goetz <goetz.lindenmaier at sap.com<mailto:goetz.lindenmaier at sap.com>>; Doerr, Martin <martin.doerr at sap.com<mailto:martin.doerr at sap.com>>
Subject: RFR : 8210205 : build fails on AIX in hotspot cpp tests (for example getstacktr001.cpp)

Hello,  please review this small fix to repair our AIX build .
Recent changes to jdk/jdk broke  the  build .

We  get clashes   with defines from system headers  in a few compilation units, for example :


"/openjdk/nb/rs6000_64/nightly/jdk/test/hotspot/jtreg/vmTestbase/nsk/jvmti/GetStackTrace/getstacktr001/getstacktr001.cpp", line 69.9: 1540-0848 (S)
The macro name "NUMBER_OF_FRAMES" is already defined with a different definition.
"/usr/include/sys/mstsave.h", line 260.9: 1540-0425 (I) "NUMBER_OF_FRAMES" is defined on line 260 of "/usr/include/sys/mstsave.h".



Renaming NUMBER_OF_FRAMES  fixes the issue.

Bug :

https://bugs.openjdk.java.net/browse/JDK-8210205


webrev :

http://cr.openjdk.java.net/~mbaesken/webrevs/8210205/



Thanks, Matthias