RFR: JDK-8214710 Fix hg log in update_copyright_year.sh

Tim Bell tim.bell at oracle.com
Mon Dec 3 16:46:21 UTC 2018


Magnus:

On 12/03/18 08:16, Alan Bateman wrote:
>
>
> On 03/12/2018 16:10, Magnus Ihse Bursie wrote:
>> The commands for hg log is missing -l1, which will limit the log to
>> just the revision specified. Instead, all revisions from repo creation
>> will now be included, and the script fails to work.
>>
>> I will publish a separate changeset with missed copyright year updates
>> in the build system.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8214710
>> WebRev:
>> http://cr.openjdk.java.net/~ihse/JDK-8214710-fix-update-copyright-year/webrev.01
>>
>>
> This looks okay to me.
>
> For the follow-on "missing copyright year updates" then maybe the entire
> source should be done rather than doing it in piecemeal.
>
> -Alan

Looks good to me as well.

Tim




More information about the build-dev mailing list