RFR: JDK-8214718 Update missing copyright year in build system

Erik Joelsson erik.joelsson at oracle.com
Mon Dec 3 17:35:32 UTC 2018


Looks good.

/Erik

On 2018-12-03 08:30, Magnus Ihse Bursie wrote:
> Not all changes in 2018 in the build system were accompanied by 
> updates of the copyright year. Add 2018 to files that were actually 
> modified in 2018, but did not get the copyright line updated.
>
> I have found this list by running the update_copyright_year script, 
> and then manually verified that the files were indeed modified in 
> 2018, and was not a "dummy" change (such as modifying the copyright 
> header...). Files with "dummy" changes were reverted. I have also 
> manually verified that the script did indeed rewrite the header 
> correctly. (I do not trust scripts... The only good script is a dead 
> scr... nah. But I do not trust them.)
>
> As usual, the easiest way to review a change like this is to look at 
> the patch file in webrev.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8214718
> WebRev: 
> http://cr.openjdk.java.net/~ihse/JDK-8214718-update-missing-copyright-year-2018/webrev.01
>
> And, for reference, here is the list of the latest changes for every 
> file I've updated:
>
> Latest entry for bin/idea.sh
> changeset:   52517:59065e5d56ec
> user:        stuefe
> date:        Wed Nov 14 09:19:31 2018 +0100
> summary:     8213591: running bin/idea.sh in Cygwin: generated project 
> cannot be imported
>
> Latest entry for make/BuildStatic.gmk
> changeset:   52065:dea8a62cdfc3
> user:        erikj
> date:        Tue Oct 09 14:57:23 2018 -0700
> summary:     8211724: Change mkdir -p to MakeDir macro where possible
>
> Latest entry for make/Bundles.gmk
> changeset:   52774:56ca125c973b
> user:        shurailine
> date:        Thu Nov 29 06:34:46 2018 -0800
> summary:     8214309: Enhance makefiles to allow generating JCov 
> instrumented build
>
> Latest entry for make/CompileDemos.gmk
> changeset:   50831:59c6972e39fa
> user:        prr
> date:        Fri Jun 22 13:21:23 2018 -0700
> summary:     8205494: Convert or remove all AWT applet demos
>
> Latest entry for make/CompileToolsHotspot.gmk
> changeset:   50330:2cbc42a5764b
> user:        dlong
> date:        Thu May 31 10:38:05 2018 -0700
> summary:     8202670: Update Graal
>
> Latest entry for make/CopyInterimCLDRConverter.gmk
> changeset:   52065:dea8a62cdfc3
> user:        erikj
> date:        Tue Oct 09 14:57:23 2018 -0700
> summary:     8211724: Change mkdir -p to MakeDir macro where possible
>
> Latest entry for make/CreateBuildJdkCopy.gmk
> changeset:   52065:dea8a62cdfc3
> user:        erikj
> date:        Tue Oct 09 14:57:23 2018 -0700
> summary:     8211724: Change mkdir -p to MakeDir macro where possible
>
> Latest entry for make/CreateJmods.gmk
> changeset:   50142:f348e5d4769b
> user:        erikj
> date:        Fri May 11 08:39:21 2018 -0700
> summary:     8202914: Let custom makefile override jmod intput dir 
> locations
>
> Latest entry for make/GenerateModuleSummary.gmk
> changeset:   52065:dea8a62cdfc3
> user:        erikj
> date:        Tue Oct 09 14:57:23 2018 -0700
> summary:     8211724: Change mkdir -p to MakeDir macro where possible
>
> Latest entry for make/GensrcModuleInfo.gmk
> changeset:   52065:dea8a62cdfc3
> user:        erikj
> date:        Tue Oct 09 14:57:23 2018 -0700
> summary:     8211724: Change mkdir -p to MakeDir macro where possible
>
> Latest entry for make/InterimImage.gmk
> changeset:   49207:2a25589b5971
> user:        redestad
> date:        Mon Mar 12 19:36:59 2018 +0100
> summary:     8199469: Disable generate-jli-classes when building 
> interim-image
>
> Latest entry for make/ZipSource.gmk
> changeset:   50590:5fa19bad622d
> user:        erikj
> date:        Fri Jun 15 09:53:28 2018 -0700
> summary:     8204973: Add build support for filtering translations
>
> Latest entry for make/autoconf/boot-jdk.m4
> changeset:   51822:f3c1945fa8aa
> user:        ihse
> date:        Thu Sep 20 18:39:53 2018 +0200
> summary:     8210960: Allow --with-boot-jdk-jvmargs to work during 
> configure
>
> Latest entry for make/autoconf/build-aux/config.guess
> changeset:   50311:04c8eba70a59
> user:        erikj
> date:        Wed May 30 09:45:24 2018 -0700
> summary:     8204091: Configure broken on MIPS when uname returns 
> mipsel or mips64el
>
> Latest entry for make/autoconf/jdk-version.m4
> changeset:   52724:0bdbf854472f
> user:        rriggs
> date:        Wed Nov 28 15:53:49 2018 -0500
> summary:     4947890: Minimize JNI upcalls in system-properties 
> initialization
>
> Latest entry for make/autoconf/lib-bundled.m4
> changeset:   48758:ba19a21d727d
> user:        erikj
> date:        Wed Feb 07 09:48:43 2018 -0800
> summary:     8196951: jdk build fails with clang: error: no such file 
> or directory: '@LIBZ_CFLAGS@'
>
> Latest entry for make/autoconf/toolchain_windows.m4
> changeset:   50639:c12c79a49ca2
> user:        erikj
> date:        Tue Jun 19 16:44:41 2018 +0200
> summary:     8205183: Warning about using VS2017 should be removed
>
> Latest entry for make/common/JarArchive.gmk
> changeset:   52595:16609197022c
> user:        redestad
> date:        Fri Nov 16 23:39:51 2018 +0100
> summary:     8061281: Microbenchmark suite build support, directory 
> layout and sample benchmarks
>
> Latest entry for make/common/JavaCompilation.gmk
> changeset:   52065:dea8a62cdfc3
> user:        erikj
> date:        Tue Oct 09 14:57:23 2018 -0700
> summary:     8211724: Change mkdir -p to MakeDir macro where possible
>
> Latest entry for make/common/TextFileProcessing.gmk
> changeset:   48943:e61816fc5276
> user:        erikj
> date:        Fri Feb 23 22:09:16 2018 +0100
> summary:     8198569: SetupTextFileProcessing should use sed with 'g'
>
> Latest entry for make/common/ZipArchive.gmk
> changeset:   52065:dea8a62cdfc3
> user:        erikj
> date:        Tue Oct 09 14:57:23 2018 -0700
> summary:     8211724: Change mkdir -p to MakeDir macro where possible
>
> Latest entry for make/copy/Copy-java.desktop.gmk
> changeset:   49537:149dc554808c
> user:        erikj
> date:        Thu Apr 05 23:46:05 2018 +0200
> summary:     8199539: Provide a standard way for the build to filter 
> un-needed legal .md files
>
> Latest entry for make/copy/CopyCommon.gmk
> changeset:   49540:9704789737c1
> user:        erikj
> date:        Fri Apr 06 02:52:24 2018 +0200
> summary:     8201222: JDK-8199539 broke the OpenJDK build
>
> Latest entry for make/data/fontconfig/macosx.fontconfig.properties
> changeset:   50348:008f416a79cb
> user:        prr
> date:        Fri May 25 16:23:17 2018 -0700
> summary:     8191522: Remove Bigelow&Holmes Lucida fonts from JDK sources
>
> Latest entry for make/data/fontconfig/solaris.fontconfig.properties
> changeset:   50348:008f416a79cb
> user:        prr
> date:        Fri May 25 16:23:17 2018 -0700
> summary:     8191522: Remove Bigelow&Holmes Lucida fonts from JDK sources
>
> Latest entry for make/data/fontconfig/windows.fontconfig.properties
> changeset:   50836:b9456394d24f
> user:        pkbalakr
> date:        Mon Jun 25 16:01:01 2018 +0530
> summary:     8202696: Remove exclusion range for phonetic chars in 
> windows fontconfig.properties
>
> Latest entry for make/devkit/createMacosxDevkit6.sh
> changeset:   48755:fe377d6591ef
> user:        erikj
> date:        Tue Feb 06 16:33:38 2018 -0800
> summary:     8196895: Create devkit for Macosx with Xcode 9.2
>
> Latest entry for make/devkit/createSolarisDevkit12.4.sh
> changeset:   48919:c7e84c0a51c3
> user:        erikj
> date:        Tue Feb 20 07:51:51 2018 -0800
> summary:     8198328: Create devkit for Solaris with developer studio 
> 12.6 and Solaris11.3
>
> Latest entry for make/devkit/createWindowsDevkit2013.sh
> changeset:   48678:bcce1fa183e7
> user:        erikj
> date:        Mon Jan 29 17:58:12 2018 +0100
> summary:     8196108: Add build support for VS 2015/2017
>
> Latest entry for make/gendata/GendataFontConfig.gmk
> changeset:   52065:dea8a62cdfc3
> user:        erikj
> date:        Tue Oct 09 14:57:23 2018 -0700
> summary:     8211724: Change mkdir -p to MakeDir macro where possible
>
> Latest entry for make/gendata/GendataHtml32dtd.gmk
> changeset:   52065:dea8a62cdfc3
> user:        erikj
> date:        Tue Oct 09 14:57:23 2018 -0700
> summary:     8211724: Change mkdir -p to MakeDir macro where possible
>
> Latest entry for make/gendata/GendataTZDB.gmk
> changeset:   52065:dea8a62cdfc3
> user:        erikj
> date:        Tue Oct 09 14:57:23 2018 -0700
> summary:     8211724: Change mkdir -p to MakeDir macro where possible
>
> Latest entry for make/gensrc/Gensrc-jdk.localedata.gmk
> changeset:   50590:5fa19bad622d
> user:        erikj
> date:        Fri Jun 15 09:53:28 2018 -0700
> summary:     8204973: Add build support for filtering translations
>
> Latest entry for make/gensrc/GensrcCharsetCoder.gmk
> changeset:   52065:dea8a62cdfc3
> user:        erikj
> date:        Tue Oct 09 14:57:23 2018 -0700
> summary:     8211724: Change mkdir -p to MakeDir macro where possible
>
> Latest entry for make/gensrc/GensrcCommonLangtools.gmk
> changeset:   52065:dea8a62cdfc3
> user:        erikj
> date:        Tue Oct 09 14:57:23 2018 -0700
> summary:     8211724: Change mkdir -p to MakeDir macro where possible
>
> Latest entry for make/gensrc/GensrcLocaleData.gmk
> changeset:   52065:dea8a62cdfc3
> user:        erikj
> date:        Tue Oct 09 14:57:23 2018 -0700
> summary:     8211724: Change mkdir -p to MakeDir macro where possible
>
> Latest entry for make/gensrc/GensrcMisc.gmk
> changeset:   52724:0bdbf854472f
> user:        rriggs
> date:        Wed Nov 28 15:53:49 2018 -0500
> summary:     4947890: Minimize JNI upcalls in system-properties 
> initialization
>
> Latest entry for make/gensrc/GensrcModuleLoaderMap.gmk
> changeset:   52065:dea8a62cdfc3
> user:        erikj
> date:        Tue Oct 09 14:57:23 2018 -0700
> summary:     8211724: Change mkdir -p to MakeDir macro where possible
>
> Latest entry for make/gensrc/GensrcSwing.gmk
> changeset:   52065:dea8a62cdfc3
> user:        erikj
> date:        Tue Oct 09 14:57:23 2018 -0700
> summary:     8211724: Change mkdir -p to MakeDir macro where possible
>
> Latest entry for make/gensrc/GensrcVarHandles.gmk
> changeset:   52220:9c260a6b6471
> user:        mchung
> date:        Mon Oct 22 17:00:04 2018 -0700
> summary:     8207146: Rename jdk.internal.misc.Unsafe::xxxObject to 
> xxxReference
>
> Latest entry for make/hotspot/gensrc/GenerateSources.gmk
> changeset:   50113:caf115bb98ad
> user:        egahlin
> date:        Tue May 15 20:24:34 2018 +0200
> summary:     8199712: Flight Recorder
>
> Latest entry for 
> make/hotspot/src/classes/build/tools/projectcreator/BuildConfig.java
> changeset:   50113:caf115bb98ad
> user:        egahlin
> date:        Tue May 15 20:24:34 2018 +0200
> summary:     8199712: Flight Recorder
>
> Latest entry for 
> make/jdk/src/classes/build/tools/classlist/HelloClasslist.java
> changeset:   52177:430e6421d503
> user:        redestad
> date:        Wed Oct 17 17:35:26 2018 +0200
> summary:     8212597: Optimize String concatenation setup when using 
> primitive operands
>
> Latest entry for 
> make/jdk/src/classes/build/tools/module/GenModuleInfoSource.java
> changeset:   51499:fdd768b9865e
> user:        mchung
> date:        Wed Aug 22 13:47:47 2018 -0500
> summary:     8167314: Enable the check to detect duplicate provides in 
> in GenModuleInfoSource
>
> Latest entry for 
> make/jdk/src/classes/build/tools/module/ModuleInfoExtraTest.java
> changeset:   51499:fdd768b9865e
> user:        mchung
> date:        Wed Aug 22 13:47:47 2018 -0500
> summary:     8167314: Enable the check to detect duplicate provides in 
> in GenModuleInfoSource
>
> Latest entry for make/langtools/build.xml
> changeset:   51565:7e5f08c619e3
> user:        mcimadamore
> date:        Wed Aug 29 11:25:51 2018 +0100
> summary:     8209064: Make intellij support more robust after changes 
> for 2018.2
>
> Latest entry for 
> make/langtools/intellij/template/src/idea/LangtoolsIdeaAntLogger.java
> changeset:   51565:7e5f08c619e3
> user:        mcimadamore
> date:        Wed Aug 29 11:25:51 2018 +0100
> summary:     8209064: Make intellij support more robust after changes 
> for 2018.2
>
> Latest entry for 
> make/langtools/tools/propertiesparser/PropertiesParser.java
> changeset:   51737:30e6a0b9d691
> user:        ihse
> date:        Fri Sep 14 09:16:51 2018 +0200
> summary:     8210731: PropertiesParser does not produce reproducible 
> output
>
> Latest entry for 
> make/langtools/tools/propertiesparser/gen/ClassGenerator.java
> changeset:   51985:08c296fe9458
> user:        cushon
> date:        Mon Oct 01 21:14:58 2018 -0700
> summary:     8211057: Gensrc step CompileProperties generates unstable 
> CompilerProperties output
>
> Latest entry for make/launcher/Launcher-jdk.aot.gmk
> changeset:   50104:4ea7917929b9
> user:        aph
> date:        Mon May 14 12:03:59 2018 +0100
> summary:     8185505: AArch64: Port AOT to AArch64
>
> Latest entry for make/nashorn/build.xml
> changeset:   52783:5827f12ecbf0
> user:        hannesw
> date:        Fri Nov 30 15:43:37 2018 +0100
> summary:     8214525: Bit rot in Nashorn Ant script
>
> Latest entry for make/rmic/Rmic-java.management.rmi.gmk
> changeset:   52065:dea8a62cdfc3
> user:        erikj
> date:        Tue Oct 09 14:57:23 2018 -0700
> summary:     8211724: Change mkdir -p to MakeDir macro where possible
>
> Latest entry for make/scripts/compare_exceptions.sh.incl
> changeset:   51781:dd737bf6abde
> user:        ihse
> date:        Tue Sep 18 10:35:42 2018 +0200
> summary:     8210750: Clean up compare.sh exceptions
>
> /Magnus
>


More information about the build-dev mailing list