RFR(XS): 8214063: [AIX] Disable symbol visibility flags

[Volker Simonis]

Hi Adam,

I've just pushed the change:

http://hg.openjdk.java.net/jdk/jdk/rev/fc54d27e58d8

Best regards,
Volker
On Thu, Nov 29, 2018 at 5:54 PM Adam Farley8 <adam.farley at uk.ibm.com> wrote:
>
> Hi All,
>
> The build passed on xlC 13.1 with the makefile patch I proposed (good catch on the comments Volkar!).
>
> With Volkar, Erik, Matthias, and Magnus all approving the change, it sounds like we're good to merge!
>
> Volkar, can you do the honours?
>
> Best Regards
>
> Adam Farley
> IBM Runtimes
>
> P.S. I approve the change too. ;)
>
>
> Volker Simonis <volker.simonis at gmail.com> wrote on 29/11/2018 11:54:33:
>
> > From: Volker Simonis <volker.simonis at gmail.com>
> > To: Magnus Ihse Bursie <magnus.ihse.bursie at oracle.com>
> > Cc: build-dev <build-dev at openjdk.java.net>, ppc-aix-port-
> > dev at openjdk.java.net, adam.farley at uk.ibm.com
> > Date: 29/11/2018 11:54
> > Subject: Re: RFR(XS): 8214063: [AIX] Disable symbol visibility flags
> >
> > On Thu, Nov 29, 2018 at 12:20 PM Magnus Ihse Bursie
> > <magnus.ihse.bursie at oracle.com> wrote:
> > >
> > > On 2018-11-27 16:33, Volker Simonis wrote:
> > >
> > > > Hi,
> > > >
> > > > can I please have a review for the following trivial change which
> > > > simply disables the symbol visibility flags on AIX:
> > > >
> > > > https://urldefense.proofpoint.com/v2/url?
> > u=http-3A__cr.openjdk.java.net_-7Esimonis_webrevs_2018_8214063_&d=DwIBaQ&c=jf_iaSHvJObTbx-
> > siA1ZOg&r=P5m8KWUXJf-
> > CeVJc0hDGD9AQ2LkcXDC0PMV9ntVw5Ho&m=6y4Npxy6aG4q8E9Xca--
> > YxF4UGVrVEIqu_wVvivFVUA&s=DptrWUUtJCcpUCbCWkkBOeFJCVk5im3hm9T_DcD0Jd8&e=
> > > > https://urldefense.proofpoint.com/v2/url?
> > u=https-3A__bugs.openjdk.java.net_browse_JDK-2D8214063&d=DwIBaQ&c=jf_iaSHvJObTbx-
> > siA1ZOg&r=P5m8KWUXJf-
> > CeVJc0hDGD9AQ2LkcXDC0PMV9ntVw5Ho&m=6y4Npxy6aG4q8E9Xca--
> > YxF4UGVrVEIqu_wVvivFVUA&s=jBFABkJb5E5W9K8pMX794-3gnpLfPyi3oASA1kizQ7A&e=
> > > Looks good to me. I am sorry for the mess I caused by optimisically
> > > trying to fix things on a platform I could not compile on... :(
> > >
> >
> > Thanks for the review and don't worry! We really appreciate your
> > continued help. It's really us who should have tested and spotted the
> > problems earlier :)
> >
> > Regards,
> > Volker
> >
> > > This also reminds me that the visibility flags *really* should move into
> > > configure/spec, not be sprinkled like this in the make files.
> > >
> > > /Magnus
> > > >
> > > > Change "8202322: AIX: symbol visibility flags not support on xlc 12.1"
> > > > [1] blindly introduced these flags for all xlC compiler versions >
> > > > 12.1 without ever testing it (which should not have happened). Now
> > > > that people are starting to really use xlC 13 it turns out that there
> > > > is more to do than just enabling the flags. This future work is
> > > > covered by "8204541: Correctly support AIX xlC 13.1 symbol visibility
> > > > flags".
> > > >
> > > > Thank you and best regards,
> > > > Volker
> > > >
> > > > [1] https://urldefense.proofpoint.com/v2/url?
> > u=https-3A__bugs.openjdk.java.net_browse_JDK-2D8202322&d=DwIBaQ&c=jf_iaSHvJObTbx-
> > siA1ZOg&r=P5m8KWUXJf-
> > CeVJc0hDGD9AQ2LkcXDC0PMV9ntVw5Ho&m=6y4Npxy6aG4q8E9Xca--
> > YxF4UGVrVEIqu_wVvivFVUA&s=pd7-rH7OPxeaq2g6S0dQPmb_3-8PLi8JZFKcP_Abp6Q&e=
> > > > [2] https://urldefense.proofpoint.com/v2/url?
> > u=https-3A__bugs.openjdk.java.net_browse_JDK-2D8204541&d=DwIBaQ&c=jf_iaSHvJObTbx-
> > siA1ZOg&r=P5m8KWUXJf-
> > CeVJc0hDGD9AQ2LkcXDC0PMV9ntVw5Ho&m=6y4Npxy6aG4q8E9Xca--
> > YxF4UGVrVEIqu_wVvivFVUA&s=q7KHUASpF-opdcLXbTTUT1bPoKrkTeaHTtd7c2jN4rc&e=
> > >
> >
>
> Unless stated otherwise above:
> IBM United Kingdom Limited - Registered in England and Wales with number 741598.
> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU