RFR: JDK-8215952: NetBeans pre-build failed due to the incorrect configuration

[Fu Jie]

Thanks Magnus.

Best regards,
Jie


On 2018年12月30日 04:12, Magnus Ihse Bursie wrote:
> It's difficult to really review such a patch, but I skimmed through it and it looks reasonable. If it makes netbeans work for you, I'm ok with it.
>
> /Magnus
>
>> 28 dec. 2018 kl. 07:34 skrev Fu Jie <fujie at loongson.cn>:
>>
>> Hi,
>>
>> Please review this patch for a build failure with NetBeans:
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8215952
>> Webrev: http://cr.openjdk.java.net/~aoqi/8215952/webrev.00/
>>
>> Summary
>> The build failure is caused by an incorrect setting of preBuildCommand in make/nb_native/nbproject/configurations.xml.
>> And all invalid source code items in configurations.xml have been removed.
>>
>> Testing
>> OpenJDK build with NetBeans now pass.
>>
>>
>> Many thanks to David and Ao Qi.
>>
>> Best regards,
>> Jie
>>
>>
>>> On 2018/12/28 下午1:44, Ao Qi wrote:
>>> Hi,
>>>
>>> I have filed a bug and posted the patch.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8215952
>>>
>>> Webrev: http://cr.openjdk.java.net/~aoqi/8215952/webrev.00/
>>>
>>> This is my first time to do this. If there is something wrong,
>>> suggestion and correction are welcome:)
>>>
>>> Cheers,
>>> Ao Qi
>>>
>>>> On Fri, Dec 28, 2018 at 12:42 PM Fu Jie <fujie at loongson.cn> wrote:
>>>> Nice.
>>>>
>>>> Many thanks to you David.
>>>>
>>>>
>>>> Best regards,
>>>> Jie
>>>>
>>>>> On 2018/12/28 上午11:47, David Holmes wrote:
>>>>>> On 28/12/2018 1:36 pm, Fu Jie wrote:
>>>>>> Hi David,
>>>>>>
>>>>>> Thanks for your reply.
>>>>>>
>>>>>> I had tried to send the patch as an attachment last night, but the
>>>>>> mailing lists reminded me that the size of my email with such an
>>>>>> attachment was too big.
>>>>>>
>>>>>> I'm very appreciative of your help. And I'd like to follow your
>>>>>> advice to submit the patch again later.
>>>>> Ao Qi has author status now and so can post a webrev on
>>>>> cr.openjdk.java.net. Perhaps they could help you with this patch. They
>>>>> can also file a bug for this issue on https://bugs.openjdk.java.net
>>>>>
>>>>> Thanks,
>>>>> David
>>>>>
>>>>>> Best regards,
>>>>>>
>>>>>> Jie
>>>>>>
>>>>>>
>>>>>>
>>>>>>> On 2018/12/27 下午9:01, David Holmes wrote:
>>>>>>> Hi,
>>>>>>>
>>>>>>> All patches to OpenJDK must be submitted on OpenJDK infrastructure.
>>>>>>> This means either hosted on cr.openjdk.java.net or else included
>>>>>>> inline, or as attachments, to emails to the OpenJDK mailing lists.
>>>>>>> Patches hosted on github are not acceptable.
>>>>>>>
>>>>>>> Thanks,
>>>>>>> David
>>>>>>>
>>>>>>>> On 27/12/2018 10:56 pm, Fu Jie wrote:
>>>>>>>> Hi all,
>>>>>>>>
>>>>>>>>
>>>>>>>> OpenJDK build with NetBeans failed during the pre-build process.
>>>>>>>> The reason is that configuration in
>>>>>>>> make/nb_native/nbproject/configurations.xml is wrong.
>>>>>>>>
>>>>>>>> The setting that leads to the failure is:
>>>>>>>>          <preBuildCommand>sh ../configure
>>>>>>>> --with-debug-level=slowdebug
>>>>>>>> --disable-zip-debug-info</preBuildCommand>
>>>>>>>>
>>>>>>>> Two pionts were wrong here:
>>>>>>>>    1) the path of configure script specified was incorrect which
>>>>>>>> should just be "sh configure" instead of "sh ../configure".
>>>>>>>>    2) deprecated --disable-zip-debug-info was used which is now an
>>>>>>>> unrecognized option.
>>>>>>>>
>>>>>>>> The pre-build succeeded with the following configuration. For more
>>>>>>>> info., see [1].
>>>>>>>>          <preBuildCommand>sh configure
>>>>>>>> --with-debug-level=slowdebug</preBuildCommand>
>>>>>>>>
>>>>>>>>
>>>>>>>> Further more, there are too many invalid items in
>>>>>>>> make/nb_native/nbproject/configurations.xml. For example
>>>>>>>> This item is invalid since advancedThresholdPolicy.cpp had been
>>>>>>>> removed from the project.
>>>>>>>> ----------------------------------------------------------------------------
>>>>>>>>
>>>>>>>>           <item
>>>>>>>> path="../../src/hotspot/share/runtime/advancedThresholdPolicy.cpp"
>>>>>>>>                 ex="false"
>>>>>>>>                 tool="1"
>>>>>>>>                 flavor2="0">
>>>>>>>>           </item>
>>>>>>>> ----------------------------------------------------------------------------
>>>>>>>>
>>>>>>>> For more invalid items, see [2].
>>>>>>>>
>>>>>>>>
>>>>>>>> To fix the issues, make/nb_native/nbproject/configurations.xml
>>>>>>>> needs to be updated. And I made a patch[3] for this.
>>>>>>>> Could anyone help to review it? Thank you!
>>>>>>>>
>>>>>>>> [1]
>>>>>>>> https://github.com/DamonFool/MyBlog/blob/master/JVM/nb-prebuild-failed.md
>>>>>>>>
>>>>>>>> [2]
>>>>>>>> https://github.com/DamonFool/MyBlog/blob/master/JVM/nb-invalid-config-items.md
>>>>>>>>
>>>>>>>> [3]
>>>>>>>> https://github.com/DamonFool/MyWorkspace/blob/master/others/nb-config.diff
>>>>>>>>
>>>>>>>>
>>>>>>>> Best regards,
>>>>>>>> Fu Jie