RFR: JDK-8196356: Changes to m4 files don't trigger autoconf execution at build time

[Magnus Ihse Bursie]

On 2018-02-10 12:29, Thomas Stüfe wrote:
> On Sat, Feb 10, 2018 at 9:12 AM, Alan Bateman <Alan.Bateman at oracle.com>
> wrote:
>
>> On 08/02/2018 17:49, Erik Joelsson wrote:
>>
>>> The check for when to generate the generated configure script is not
>>> working quite as expected. It currently only compares timestamps if the
>>> local repository has any local changes in the make/autoconf directory. This
>>> used to make sense when we had a committed generated script, but now we
>>> actually do need to regenerate any time an input file is newer than the
>>> generated script.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8196356
>>>
>> In addition to `hg status` showing no changes, I think it will continue to
>> confuse people to generate it into a hidden directory. Was there any
>> consideration to generating into a regular directory?
>>
>>
> I agree. Also, we still generate the configure.sh into the source tree even
> if the output directory is somewhere else. I always keep my output
> directories separate from the source tree. Sometimes my source directory is
> even on a read-only share. I would prefer and also expect any temporary
> files to be placed in the output directory resp. the current directory, not
> in the source tree. Would that be possible?
As discussed in another thread, the current behaviour is no good when 
running configure outside the source tree root. We should definitely fix 
that (I thought Volker were going to publish a RFR but that didn't 
happen; I'll pick up the ball and submit a RFR). With that in place, the 
behaviour will in principle be that the output is in the current directory.

/Magnus


>
> Thanks and Kind Regards, Thomas
>
>
>> -Alan
>>