[PATCH] Freetype Directory Bug On zLinux

[Adam Farley8]

Hi John, Erik,

-- Erik's comments --

>Configure already looks in:

>$SYSROOT/usr/lib/$OPENJDK_TARGET_CPU-linux-gnu

>Which I would expect to cover your case, unless there is a mismatch 
>between s390 and s390x here. Is your OPENJDK_TARGET_CPU set to s390 or 
>s390x in this case? If this discrepancy between arch names cannot be 
>resolved, then a special case like the one you propose is needed.

My IF statement checks if OPENJDK_TARGET_CPU = s390. I have to assume that
means OPENJDK_TARGET_CPU is set to s390. Since the folder is 
s390x-linux-gnu,
it's likely the extra x causing the problem.

As detailed below, s390x and s390 are both valid OPENJDK_TARGET_CPU 
values,
according to the default generated_configure.sh file, so I think we need
to accomodate both if we want to continue supporting them. This appears 
the 
most straight-forward way to do that.

What do you think?

-- John's comments --

>> Which I would expect to cover your case, unless there is a mismatch 
>>between s390 and s390x here. Is your OPENJDK_TARGET_CPU set to s390 or 
>>s390x in this case? If this discrepancy between arch names cannot be 
resolved, 
>>then a special case like the one you propose is needed.
> From Adam's last mail it seems there is something wrong with his build
>environment:

Not as far as I can tell. In generated_configure.sh, both s390 and s390x 
are 
listed as valid OPENJDK_TARGET_CPU values.

I figure, if some code is looking for 
$SYSROOT/usr/lib/$OPENJDK_TARGET_CPU-linux-gnu
as Erik suggests, it's the fact that the $OPENJDK_TARGET_CPU value is 
s390, but
the folder name is s390x-linux-gnu (note the extra x) that's causing this.

>> From the configure output, it appears to look for it in 
x86_64-linux-gnu
>> so I don't know what to tell you.

>So, we need to figure out first the configure is looking in 
x86_64-linux-gnu
>on the s390x environment.

There's a bunch of IF statements in lib-freetype.m4 that appear to check 
platform-specific freetype locations sequentially, regardless of whether 
we have 
any evidence that we're on that platform. Hence my addition to that list 
of IF 
statements.

Best Regards

Adam Farley



From:   John Paul Adrian Glaubitz <glaubitz at physik.fu-berlin.de>
To:     Erik Joelsson <erik.joelsson at oracle.com>, Adam Farley8 
<adam.farley at uk.ibm.com>, build-dev at openjdk.java.net
Date:   12/01/2018 17:29
Subject:        Re: [PATCH] Freetype Directory Bug On zLinux



On 01/12/2018 06:03 PM, Erik Joelsson wrote:
> Which I would expect to cover your case, unless there is a mismatch 
between s390 and s390x here. Is your OPENJDK_TARGET_CPU set to s390 or 
s390x in this case? If this discrepancy between arch names cannot be 
resolved, then a special case like the one you propose is needed.
 From Adam's last mail it seems there is something wrong with his build
environment:

> From the configure output, it appears to look for it in x86_64-linux-gnu
> so I don't know what to tell you.

So, we need to figure out first the configure is looking in 
x86_64-linux-gnu
on the s390x environment.

Adrian

-- 
  .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaubitz at debian.org
`. `'   Freie Universitaet Berlin - glaubitz at physik.fu-berlin.de
   `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913





Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number 
741598. 
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU