RFR: 8207057: No debug info for assembler files

[Severin Gehwolf]

On Fri, 2018-07-13 at 10:46 +0200, Severin Gehwolf wrote:
> New webrev:
> http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8207057/webrev.02/
> 
> This leaves non-GCC toolchains unchanged since I don't know the
> relevant flags (if they even exist). I'd be happy to add them if
> somebody tells me what they should be.
> 
> New jdk-submit job should be running too.

Results are back:

Build tasks PASSED. Test tasks SUCCESSFUL.

Thanks,
Severin

> > > /Erik
> > > 
> > > On 2018-07-12 08:17, Severin Gehwolf wrote:
> > > > Hi,
> > > > 
> > > > Could I please get a review of this build fix? The problem is that no
> > > > debug info gets ever generated for assembler files in hotspot. The
> > > > proposed fix is to generated debug info via CFLAGS_DEBUG_SYMBOLS if so
> > > > requested. For example --with-native-debug-info=none no debug info is
> > > > generated. --with-native-debug-info=internal generates it. The question
> > > > is whether the assembler will accept the same debug-info related flags
> > > > as the compiler on all supported platforms (CFLAGS_DEBUG_SYMBOLS).
> > > > Thoughts?
> > > > 
> > > > Bug: https://bugs.openjdk.java.net/browse/JDK-8207057
> > > > webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8207057/webrev.01/
> > > > 
> > > > Testing:
> > > > - I've manually verified via gdb that relevant debug info is present.
> > > > - Currently running this through jdk-submit
> > > > 
> > > > Thanks,
> > > > Severin
> > > > 
> > > > PS:
> > > > 
> > > > --with-native-debug-info=internal
> > > > 
> > > > $ grep -in linux_x86_64.s build/linux-x86_64-normal-server-release/build.log 
> > > > 3549:SetupCompileNativeFile BUILD_LIBJVM_linux_x86_64.s  
> > > > 3550: [2] FILE := /disk/openjdk/upstream-sources/openjdk-head/src/hotspot/os_cpu/linux_x86/linux_x86_64.s  
> > > > 15605:Compiling linux_x86_64.s (for libjvm.so)
> > > > 15607:( /usr/bin/gcc -c -m64 -g -o /disk/openjdk/upstream-sources/openjdk-head/build/linux-x86_64-normal-server-release/hotspot/variant-server/libjvm/objs/linux_x86_64.o /disk/openjdk/upstream-sources/openjdk-head/src/hotspot/os_cpu/linux_x86/linux_x86_64.s > >(/usr/bin/tee /disk/openjdk/upstream-sources/openjdk-head/build/linux-x86_64-normal-server-release/hotspot/variant-server/libjvm/objs/linux_x86_64.o.log) 2> >(/usr/bin/tee /disk/openjdk/upstream-sources/openjdk-head/build/linux-x86_64-normal-server-release/hotspot/variant-server/libjvm/objs/linux_x86_64.o.log >&2) || ( exitcode=$? && /usr/bin/cp /disk/openjdk/upstream-sources/openjdk-head/build/linux-x86_64-normal-server-release/hotspot/variant-server/libjvm/objs/linux_x86_64.o.log /disk/openjdk/upstream-sources/openjdk-head/build/linux-x86_64-normal-server-release/make-support/failure-logs/hotspot_variant-server_libjvm_objs_linux_x86_64.o.log && /usr/bin/cp /disk/openjdk/upstream-sources/openjdk-head/build/linux-x86_64-normal-server-release/hotspot/variant-server/libjvm/objs/linux_x86_64.o.cmdline /disk/openjdk/upstream-sources/openjdk-head/build/linux-x86_64-normal-server-release/make-support/failure-logs/hotspot_variant-server_libjvm_objs_linux_x86_64.o.cmdline && exit $exitcode ) )
> > > > 
> > > > Note: -g switch is present.
> > > > 
> > > > --with-native-debug-info=none
> > > > 
> > > > $ grep -in linux_x86_64.s build/linux-x86_64-normal-server-release/build.log 
> > > > 3549:SetupCompileNativeFile BUILD_LIBJVM_linux_x86_64.s  
> > > > 3550: [2] FILE := /disk/openjdk/upstream-sources/openjdk-head/src/hotspot/os_cpu/linux_x86/linux_x86_64.s  
> > > > 12499:Compiling linux_x86_64.s (for libjvm.so)
> > > > 12653:( /usr/bin/gcc -c -m64 -o /disk/openjdk/upstream-sources/openjdk-head/build/linux-x86_64-normal-server-release/hotspot/variant-server/libjvm/objs/linux_x86_64.o /disk/openjdk/upstream-sources/openjdk-head/src/hotspot/os_cpu/linux_x86/linux_x86_64.s > >(/usr/bin/tee /disk/openjdk/upstream-sources/openjdk-head/build/linux-x86_64-normal-server-release/hotspot/variant-server/libjvm/objs/linux_x86_64.o.log) 2> >(/usr/bin/tee /disk/openjdk/upstream-sources/openjdk-head/build/linux-x86_64-normal-server-release/hotspot/variant-server/libjvm/objs/linux_x86_64.o.log >&2) || ( exitcode=$? && /usr/bin/cp /disk/openjdk/upstream-sources/openjdk-head/build/linux-x86_64-normal-server-release/hotspot/variant-server/libjvm/objs/linux_x86_64.o.log /disk/openjdk/upstream-sources/openjdk-head/build/linux-x86_64-normal-server-release/make-support/failure-logs/hotspot_variant-server_libjvm_objs_linux_x86_64.o.log && /usr/bin/cp /disk/openjdk/upstream-sources/openjdk-head/build/linux-x86_64-normal-server-release/hotspot/variant-server/libjvm/objs/linux_x86_64.o.cmdline /disk/openjdk/upstream-sources/openjdk-head/build/linux-x86_64-normal-server-release/make-support/failure-logs/hotspot_variant-server_libjvm_objs_linux_x86_64.o.cmdline && exit $exitcode ) )
> > > > 
> > > > Note: No -g switch present as expected. 
> > > 
> > >