custom extension for make/SourceRevision.gmk

[Erik Joelsson]

One thing though. Since you are renaming the top file, we need to 
coordinate pushing of this change since we are relying on the old name.

/Erik


On 2018-07-19 09:44, Erik Joelsson wrote:
>
> On 2018-07-19 09:16, Christian Thalinger wrote:
>>
>>
>> Well, the issue is this:
>>
>> exploded-image: exploded-image-base release-file
>>
>>   release-file: create-source-revision-tracker
>>
>> store-source-revision:
>>       +($(CD) $(TOPDIR)/make && $(MAKE) $(MAKE_ARGS) -f 
>> SourceRevision.gmk store-source-revision)
>>
>> create-source-revision-tracker:
>>       +($(CD) $(TOPDIR)/make && $(MAKE) $(MAKE_ARGS) -f 
>> SourceRevision.gmk create-source-revision-tracker)
>>
>> We need these targets because all isn’t really used.
>>
> Ah, the all target is tricking me and should be removed if not called 
> from anywhere. Then your suggested patch is good (except for missing 
> the :=).
>
> /Erik
>>>> +store-source-revision: $(STORE_SOURCE_REVISION_TARGET)
>>>> +
>>>> +create-source-revision-tracker: 
>>>> $(CREATE_SOURCE_REVISION_TRACKER_TARGET)
>>>> +
>>>>  all: store-source-revision create-source-revision-tracker
>>>>
>>>>  FRC: # Force target
>>>>
>>> Do you really need the separate variables? Since both of them are 
>>> built by all anyway, I would just have one variable TARGETS to which 
>>> you add everything you wish to build and finish with "all: $(TARGETS)".
>>>
>>> /Erik
>>
>