RFR: 8207849: Allow the addition of more number to the Java version string (S)

[Erik Joelsson]

This looks ok to me.

/Erik


On 2018-07-19 13:11, Tony Printezis wrote:
> Thanks for the explanation. So I think I’ll just leave it as is.
>
> New webrev:
>
> http://cr.openjdk.java.net/~tonyp/8207849/webrev.1/ 
> <http://cr.openjdk.java.net/%7Etonyp/8207849/webrev.1/>
>
> The only new changes are in the spec.gmk.in <http://spec.gmk.in> file.
>
> Tony
>
>
> —————
> Tony Printezis | @TonyPrintezis | tprintezis at twitter.com 
> <mailto:tprintezis at twitter.com>
>
>
> On July 19, 2018 at 4:01:14 PM, Erik Joelsson 
> (erik.joelsson at oracle.com <mailto:erik.joelsson at oracle.com>) wrote:
>
>>
>>
>> On 2018-07-19 12:52, Tony Printezis wrote:
>>> Erik,
>>>
>>> Many thanks for looking at this change!
>>>
>>> I can totally add the VERSION_EXTRAX variables to the spec.gmk file.
>>>
>>> Related: I was not sure what to do with 
>>> VERSION_NUMBER_ALL_POSITIONS. Right now, 
>>> VERSION_NUMBER_FOUR_POSITIONS is exposed to the spec.gmk file but 
>>> I'm not sure exactly where it’s used. Is it worth also exposing 
>>> VERSION_NUMBER_ALL_POSITIONS? I didn’t to make sure that anything 
>>> that relies on VERSION_NUMBER_FOUR_POSITIONS having exactly four 
>>> numbers didn’t break (and I’m happy to leave it as is).
>>>
>> The VERSION_NUMBER_FOUR_POSITIONS is used in windows launcher 
>> manifests (shows up if you right click a windows executable) and it's 
>> used internally at Oracle for Windows installers. I believe (but is 
>> not 100% sure) that the format with 4 numbers is specifically needed 
>> in the windows manifest case.
>>
>> /Erik
>>> Tony
>>>
>>> —————
>>> Tony Printezis | @TonyPrintezis | tprintezis at twitter.com 
>>> <mailto:tprintezis at twitter.com>
>>>
>>>
>>> On July 19, 2018 at 3:02:26 PM, Erik Joelsson 
>>> (erik.joelsson at oracle.com <mailto:erik.joelsson at oracle.com>) wrote:
>>>
>>>> Hello Tony,
>>>>
>>>> I think this looks ok. We like to keep AC_SUBST calls paired with
>>>> variables in spec.gmk.in <http://spec.gmk.in> so please add 
>>>> corresponding VERSION_EXTRAX
>>>> variables there.
>>>>
>>>> /Erik
>>>>
>>>>
>>>> On 2018-07-19 11:46, Tony Printezis wrote:
>>>> > Hi all,
>>>> >
>>>> > Here’s the webrev for this:
>>>> >
>>>> > http://cr.openjdk.java.net/~tonyp/8207849/webrev.0/ 
>>>> <http://cr.openjdk.java.net/%7Etonyp/8207849/webrev.0/>
>>>> >
>>>> > I’m no configure expert so I basically did a cut-and-paste of 
>>>> what was
>>>> > already there. If there’s a way to do this better (maybe, cut 
>>>> down on the
>>>> > awkward code replication), let let me know.
>>>> >
>>>> > The decision to allow up to 3 extra numbers was arbitrary. I can 
>>>> do more or
>>>> > fewer.
>>>> >
>>>> > Tony
>>>> >
>>>> > —————
>>>> > Tony Printezis | @TonyPrintezis | tprintezis at twitter.com 
>>>> <mailto:tprintezis at twitter.com>
>>>>
>>