RFR: 8208157: requires.VMProps throws NPE for missing properties in "release" file

Lance Andersen lance.andersen at oracle.com
Tue Jul 24 22:52:23 UTC 2018


Looks fine shura
> On Jul 24, 2018, at 6:48 PM, Alexandre (Shura) Iline <alexandre.iline at oracle.com> wrote:
> 
> Hi,
> 
> Could you please tale a quick look on this simple fix?
> 
> diff --git a/test/jtreg-ext/requires/VMProps.java b/test/jtreg-ext/requires/VMProps.java
> --- a/test/jtreg-ext/requires/VMProps.java
> +++ b/test/jtreg-ext/requires/VMProps.java
> @@ -432,7 +432,8 @@
>                 System.getProperty("java.home") + "/release"))) {
>             Properties properties = new Properties();
>             properties.load(in);
> -            return properties.getProperty("IMPLEMENTOR").replace("\"", "");
> +            String implementorProperty = properties.getProperty("IMPLEMENTOR");
> +            return (implementorProperty == null) ? "null" : implementorProperty.replace("\"", "");
>         } catch (IOException e) {
>             e.printStackTrace();
>         }
> 
> 
> Thank you.
> 
> Shura

 <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>






More information about the build-dev mailing list