RFR: 8208484: color contrast issues in javadoc
Jonathan Gibbons
jonathan.gibbons at oracle.com
Mon Jul 30 19:53:29 UTC 2018
The other/referenced bug only changed one of the colors that is changed
in this webrev,
119 tr:nth-child(even), tr:nth-child(even) th[scope=row] {
120 background: #E3E3E3;
121 }
But I note the other change is inline with the content of the
standard javadoc style file:
jdk-default.css
77 a:link {
78 color: #4A6782;
79 }
javadoc stylesheet.css
a:link, a:visited {
text-decoration:none;
color:#4A6782;
}
(Separately, I notice the a:visited colors are different, but that's a different issue.)
So, with my javadoc-dev hat on, it looks OK.
It would be good for someone from build-dev to also review/approve this change.
I note the content of the file was set up by Magnus [~ihse].
-- Jon
On 07/30/2018 02:10 AM, Priya Lakshmi Muthuswamy wrote:
> Hi,
>
> Kindly review fix for https://bugs.openjdk.java.net/browse/JDK-8208484
> webrev : http://cr.openjdk.java.net/~pmuthuswamy/8208484/webrev.00/
>
> Have set a slightly lighter shade to background and darker shade for
> foreground.
> This change is similar to
> https://bugs.openjdk.java.net/browse/JDK-8199893.
>
> org screenshot:(/specs/pack-spec.html)
>
>
> screenshot with changes:
>
>
> Thanks,
> Priya
More information about the build-dev
mailing list