RFR: JDK-8204127: Change bundle format on Windows to zip

Magnus Ihse Bursie magnus.ihse.bursie at oracle.com
Mon Jun 11 08:55:34 UTC 2018


On 2018-06-09 02:05, Erik Joelsson wrote:
> The compressed archive bundles we create are all tar.gz format. On 
> Windows that's not a very common format, requiring third party 
> applications to handle, while the zip format can be natively 
> extracted. This patch changes the bundle format for the JDK on Windows 
> to zip.
>
> This only applies to the actual product distributions. I think we 
> prefer tar.gz for all the internal bundles, like symbols and tests.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8204127
>
> Webrev: http://cr.openjdk.java.net/~erikj/8204127/webrev.01
It's okay, but I think it would be nicer to do it like this:

ifeq ($(OPENJDK_TARGET_OS), windows) JDK_BUNDLE_EXTENSION := zip else 
JDK_BUNDLE_EXTENSION := tar.gz endif JDK_BUNDLE_NAME := 
jdk-$(BASE_NAME)_bin$(DEBUG_PART).$(JDK_BUNDLE_EXTENSION)


If you accept, you don't need to redo the review. If you disagree, push 
your version. :-)

/Magnus


>
> /Erik
>




More information about the build-dev mailing list