RFR: 8205091: AIX: build errors in hotspot after 8203641: Refactor String Deduplication into shared

[Baesken, Matthias]

Hi  , thanks for looking into it.
I think I  will use  STAT_IMPL  .

Best regards, Matthias


> -----Original Message-----
> From: René Schünemann [mailto:rene.schuenemann at gmail.com]
> Sent: Freitag, 15. Juni 2018 11:08
> To: Baesken, Matthias <matthias.baesken at sap.com>
> Cc: build-dev at openjdk.java.net; hotspot-dev at openjdk.java.net
> Subject: Re: RFR: 8205091: AIX: build errors in hotspot after 8203641: Refactor
> String Deduplication into shared
> 
> Hi Matthias,
> 
> the name SI seems also quite "common" and may result in other naming
> clashes in the future.
> Maybe something more readable like STAT_IMPL?
> 
> Please also change the name in the comment:
> 
> // STAT:  String Dedup Stat implementation
> 
> Regards,
> Rene
> 
> On Fri, Jun 15, 2018 at 9:47 AM, Baesken, Matthias
> <matthias.baesken at sap.com> wrote:
> > Please review  this small  change  that fixes the AIX build after  "8203641:
> Refactor String Deduplication into shared"    .
> >
> > We are getting this  compilation error  :
> >
> /build_ci_jdk_jdk_rs6000_64/src/hotspot/share/gc/shared/stringdedup/stri
> ngDedup.hpp", line 107.38: 1540-0063 (S) The text "1" is unexpected.
> >
> >
> > Looks like the name of the second template parameter (STAT)
> >
> >     template <typename QUEUE, typename STAT>
> >     static void initialize_impl();
> >
> > is clashing with defines from the AIX system headers  (where I find  #define
> STAT  1 ) .
> > Renaming  STAT  to something else fixes the build on AIX .
> >
> > Webrev :
> >
> > http://cr.openjdk.java.net/~mbaesken/webrevs/8205091/
> >
> > Bug :
> >
> > https://bugs.openjdk.java.net/browse/JDK-8205091
> >
> >
> > Thanks, Matthias