RFR: 8205091: AIX: build errors in hotspot after 8203641: Refactor String Deduplication into shared

[Zhengyu Gu]

Hi,

Whatever the name you come up, could you please also update 
stringDedup.inline.hpp to use the same names?

Thomas Schatzl pointed out the inconsistent, I made change to use S and 
Q, but apparently, I messed up in final patch.

Otherwise, looks good to me too.

-Zhengyu



On 06/15/2018 06:36 AM, Thomas Stüfe wrote:
> Hi Matthias,
> 
> Good catch. Patch for me is good if you guys agree on a good uncommon name.
> 
> Gruß Thomas
> 
> On Fri, Jun 15, 2018, 09:48 Baesken, Matthias <matthias.baesken at sap.com>
> wrote:
> 
>> Please review  this small  change  that fixes the AIX build after
>> "8203641: Refactor String Deduplication into shared"    .
>>
>> We are getting this  compilation error  :
>> /build_ci_jdk_jdk_rs6000_64/src/hotspot/share/gc/shared/stringdedup/stringDedup.hpp",
>> line 107.38: 1540-0063 (S) The text "1" is unexpected.
>>
>>
>> Looks like the name of the second template parameter (STAT)
>>
>>      template <typename QUEUE, typename STAT>
>>      static void initialize_impl();
>>
>> is clashing with defines from the AIX system headers  (where I find
>> #define STAT  1 ) .
>> Renaming  STAT  to something else fixes the build on AIX .
>>
>> Webrev :
>>
>> http://cr.openjdk.java.net/~mbaesken/webrevs/8205091/
>>
>> Bug :
>>
>> https://bugs.openjdk.java.net/browse/JDK-8205091
>>
>>
>> Thanks, Matthias
>>