[8u] RFR: 8148351: Only display resolved symlink for compiler, do not change path

Erik Joelsson erik.joelsson at oracle.com
Tue Jun 19 17:12:40 UTC 2018


This looks good to me.

/Erik


On 2018-06-19 09:57, Severin Gehwolf wrote:
> Hi,
>
> After discussion in [1], please review this revised JDK 8u backport of
> JDK-8148351. When the compiler is a symlink to ccache it'll continue to
> use it's work-around to keep the Oracle JDK 8 build working. If the
> compiler isn't a symlink it'll print this as a configure message and
> won't do the ccache work-around (which it did prior this patch).
>
> Example:
>
> Before:
>
> checking for gcc... /usr/bin/gcc
> checking resolved symbolic links for CC... /usr/bin/gcc
> checking if CC is disguised ccache... no, keeping CC
> configure: Using gcc C compiler version 8.1.1 [gcc (GCC) 8.1.1 20180502 (Red Hat 8.1.1-1)]
>
> After:
>
> checking for gcc... /usr/bin/gcc
> checking resolved symbolic links for CC... no symlink
> configure: Using gcc C compiler version 8.1.1 [gcc (GCC) 8.1.1 20180502 (Red Hat 8.1.1-1)]
>
> webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8148351/webrev.02/
>
> Thoughts?
>
> Thanks,
> Severin
>
> [1] http://mail.openjdk.java.net/pipermail/build-dev/2018-June/022444.html




More information about the build-dev mailing list