RFR: JDK-8200115: System property java.vm.vendor value includes quotation marks

Tim Bell tim.bell at oracle.com
Tue Jun 19 21:40:58 UTC 2018


Erik:

> Since JDK-8189761, the java.vm.vendor string for an OracleJDK build
> contains quotation marks. This would also be true for any other build of
> OpenJDK where the user set the --with-vendor-name configure option.
>
> I found the culprit of this to be the combination of the build setting
> the preprocessor flag as -DVENDOR='"value"' (double quotes inside single
> quotes) and vm_version.cpp using the XSTR macro to convert the value of
> VENDOR into a C string. The -DVENDOR argument is also given to libjava,
> where System.c does not apply a similar conversion, so it requires the
> double quotes to be supplied on the command line.
>
> I found the simplest solution for unifying the behavior between libjvm
> and libjava to be to remove the XSTR macro call in vm_version.cpp.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8189761

Er ... the follow-on bug report is:
    https://bugs.openjdk.java.net/browse/JDK-8200115

> Webrev: http://cr.openjdk.java.net/~erikj/8200115/webrev.01/
>
> Testing: mach5 tier1

Looks good.

/Tim




More information about the build-dev mailing list