Python issues with defpath and jcheck

[Erik Joelsson]

Hello John,

I have a patch on review for fixing trees to work with Mercurial 4.6:

http://mail.openjdk.java.net/pipermail/hg-tools-dev/2018-June/000236.html

It looks like the defpath plugin is suffering similar problems. If you 
want to fix your local copy, Mercurial moved the method util.Abort to 
error.Abort.

/Erik


On 2018-06-25 11:30, John Paul Adrian Glaubitz wrote:
> Hi!
>
> I have tried to submit a patch to the submit repository today and was
> presented with a Python backtrace. I have already updated both "defpath"
> and "jcheck" to their latest version from Mercurual (trace below).
>
> Has anyone else seen this?
>
> glaubitz at z6:..incoming/submit> hg defpath -du glaubitz
> ** Unknown exception encountered with possibly-broken third-party extension jcheck
> ** which supports versions unknown of Mercurial.
> ** Please disable jcheck and try your action again.
> ** If that fixes the bug please report it to the extension author.
> ** Python 2.7.15 (default, May  1 2018, 05:55:50) [GCC 7.3.0]
> ** Mercurial Distributed SCM (version 4.6.1)
> ** Extensions loaded: strip, mq, histedit, purge, jcheck, defpath
> Traceback (most recent call last):
>    File "/usr/bin/hg", line 41, in <module>
>      dispatch.run()
>    File "/usr/lib/python2.7/dist-packages/mercurial/dispatch.py", line 90, in run
>      status = (dispatch(req) or 0)
>    File "/usr/lib/python2.7/dist-packages/mercurial/dispatch.py", line 210, in dispatch
>      ret = _runcatch(req)
>    File "/usr/lib/python2.7/dist-packages/mercurial/dispatch.py", line 351, in _runcatch
>      return _callcatch(ui, _runcatchfunc)
>    File "/usr/lib/python2.7/dist-packages/mercurial/dispatch.py", line 359, in _callcatch
>      return scmutil.callcatch(ui, func)
>    File "/usr/lib/python2.7/dist-packages/mercurial/scmutil.py", line 160, in callcatch
>      return func()
>    File "/usr/lib/python2.7/dist-packages/mercurial/dispatch.py", line 341, in _runcatchfunc
>      return _dispatch(req)
>    File "/usr/lib/python2.7/dist-packages/mercurial/dispatch.py", line 971, in _dispatch
>      cmdpats, cmdoptions)
>    File "/usr/lib/python2.7/dist-packages/mercurial/dispatch.py", line 727, in runcommand
>      ret = _runcommand(ui, options, cmd, d)
>    File "/usr/lib/python2.7/dist-packages/mercurial/dispatch.py", line 979, in _runcommand
>      return cmdfunc()
>    File "/usr/lib/python2.7/dist-packages/mercurial/dispatch.py", line 968, in <lambda>
>      d = lambda: util.checksignature(func)(ui, *args, **strcmdopt)
>    File "/usr/lib/python2.7/dist-packages/mercurial/util.py", line 1555, in check
>      return func(*args, **kwargs)
>    File "/usr/lib/python2.7/dist-packages/mercurial/util.py", line 1555, in check
>      return func(*args, **kwargs)
>    File "/usr/lib/python2.7/dist-packages/hgext/mq.py", line 3599, in mqcommand
>      return orig(ui, repo, *args, **kwargs)
>    File "/usr/lib/python2.7/dist-packages/mercurial/util.py", line 1555, in check
>      return func(*args, **kwargs)
>    File "/home/glaubitz/upstream/defpath/defpath.py", line 352, in cmd_defpath
>      return defpath(ui, repo, peer, peer_push, walk_self, opts)
>    File "/home/glaubitz/upstream/defpath/defpath.py", line 287, in defpath
>      except util.Abort, x:
> AttributeError: 'module' object has no attribute 'Abort'
> glaubitz at z6:..incoming/submit>
>