RFR 8204492 Add deprecation annotation to Nashorn APIs and warning to nashorn, jjs
Sundararajan Athijegannathan
sundararajan.athijegannathan at oracle.com
Thu Jun 28 04:53:22 UTC 2018
Only -deprecation still results in build failure :( I'll go with what
I've now to push the change before the deadline -- and we can revisit
better makefile option in a future patch.
Thanks,
-Sundar
On 27/06/18, 9:29 PM, Erik Joelsson wrote:
> If it's just deprecation you want to remove, then
> -Xlint:all,-deprecation should be enough to add. The current argument
> for jdk.scripting.nashorn is -Xlint:all (if I'm not mistaken).
>
> /Erik
>
>
> On 2018-06-27 08:59, Sundararajan Athijegannathan wrote:
>> Hi Erik,
>>
>> Yes, nashorn is warning free afaik. Besides nashorn is being
>> deprecated. No further development expected other than perhaps
>> occasional bug fixes.
>>
>> We need to disable javac deprecation warnings. Without this javac
>> deprecation warnings cause build failure.
>>
>> -Sundar
>>
>> On 27/06/18, 9:11 PM, Erik Joelsson wrote:
>>> Hello Sundar,
>>>
>>> Adding $(DISABLE_WARNINGS) disables a lot of warnings. Isn't
>>> jdk.scripting.nashorn pretty much warning frree now? What warnings
>>> do you really need to disable?
>>>
>>> /Erik
>>>
>>>
>>> On 2018-06-26 21:19, Sundararajan Athijegannathan wrote:
>>>> Forgot to CC build-dev for makefile changes.
>>>>
>>>> -Sundar
>>>>
>>>> On 27/06/18, 9:46 AM, Sundararajan Athijegannathan wrote:
>>>>> Please review.
>>>>>
>>>>> Bug https://bugs.openjdk.java.net/browse/JDK-8204492
>>>>> Webrev http://cr.openjdk.java.net/~sundar/8204492/webrev.01
>>>>>
>>>>> Related:
>>>>>
>>>>> JEP http://openjdk.java.net/jeps/335
>>>>> CSR https://bugs.openjdk.java.net/browse/JDK-8205594
>>>>>
>>>>> Thanks,
>>>>> -Sundar
>>>>>
>>>
>
More information about the build-dev
mailing list