RFR: JDK-8198751 Refactor SetupNativeCompilation to take NAME and TYPE

[Erik Joelsson]

Looks good.

/Erik


On 2018-02-27 03:15, Magnus Ihse Bursie wrote:
> Currently, SetupNativeCompilation takes as "main" argument either
> LIBRARY := $name, PROGRAM := $name or STATIC_LIBRARY := $name.
>
> This confounds two distinct concepts: the name of the generated 
> binary, and the type of binary to create. Instead, we should have a 
> NAME argument and a TYPE argument.
>
> I also took the liberty of updating the code to more modern standards 
> wrt whitespace, and fixed the "Yoda style" if conditions.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8198751
> WebRev: 
> http://cr.openjdk.java.net/~ihse/JDK-8198751-fix-NativeCompilation-NAME-and-TYPE/webrev.01
>
> /Magnus
>