RFR 8198834: (ch) Enable java/nio/channels/spi/SelectorProvider/inheritedChannel/InheritedChannelTest.java on linux-x64

Alan Bateman Alan.Bateman at oracle.com
Fri Mar 2 07:52:20 UTC 2018



On 01/03/2018 22:53, Brian Burkhalter wrote:
> I think shorter is better:
>
> http://cr.openjdk.java.net/~bpb/8198834/webrev.01/ 
> <http://cr.openjdk.java.net/%7Ebpb/8198834/webrev.01/>
>
> I’ll hold off pushing until Alan comments again.
>
libInheritedLauncher.c looks okay (although still very strange to have 
the "lib" prefix but that is not your doing). I assume the copyright 
range should be 2003, 2018 (to match Launcher.java) as this is not a new 
file in 2018.

So I think you good to go and it's great to have the .so files removed 
from the repos.

-Alan




More information about the build-dev mailing list