RFR: JDK-8199103 Can't use COMPARE_BUILD with PATCH from custom root
Erik Joelsson
erik.joelsson at oracle.com
Tue Mar 6 14:59:42 UTC 2018
Looks good.
When looking at this patch, I realized that topdir has a different
meaning depending on if you are in the HAS_SPEC conditional or not. In
the first section, topdir is always the open root dir, but in the else
section it is set to CUSTOM_ROOT if available. This is rather confusing.
Could we unify the value of this variable?
/Erik
On 2018-03-06 01:23, Magnus Ihse Bursie wrote:
> This fix will enable patch files for COMPARE_BUILD to be hosted in a
> custom root.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8199103
> WebRev:
> http://cr.openjdk.java.net/~ihse/JDK-8199103-use-PATCH-in-COMPARE_BUILD-custom-root/webrev.01
>
> /Magnus
More information about the build-dev
mailing list