RFR: JDK-8199428: install-file macro fails on filenames with space on Solaris

Sat Mar 10 08:46:10 UTC 2018

Looks good to me. 

/Magnus

> 10 mars 2018 kl. 00:42 skrev Erik Joelsson <erik.joelsson at oracle.com>:
> 
> A while back I implemented support for handling filenames with space in them in the macros SetupCopyFiles and install-file. To verify this functionality I added tests to our test-make suite. These tests currently fail on Solaris. We currently don't use this functionality on Solaris, but keeping the tests passing is still preferable.
> 
> The problem is when using the $(@D) and $(@<) variants to extract the directory or filename of the target or source file in a recipe, we first need to EncodeSpace, as otherwise the ? seems to be evaluating before the implicit $(dir) or $(notdir) is called.
> 
> This patch adds those EncodeSpace calls and makes all the test-make tests pass on Solaris.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8199428
> 
> Webrev: http://cr.openjdk.java.net/~erikj/8199428/webrev.01/
> 
> /Erik
> 