RFR: JDK-8199639 Introduce SetupJdkLibrary and SetupJdkExecutable
Magnus Ihse Bursie
magnus.ihse.bursie at oracle.com
Wed Mar 14 23:34:37 UTC 2018
We have a lot of code duplication in all our calls to
SetupNativeCompilation. This patch introduces a pair of functions,
SetupJdkLibrary and SetupJdkExecutable, which wraps
SetupNativeCompilation and sets up typical default values for our JDK
libraries.
The long-term idea here is that even more functionality (e.g. basic
LDFLAGS and CFLAGS) should move into these two functions, but for
simplicity, this patch just does the most basic cleanup.
Not all compilations were easily converted. Those were left behind at
using SetupNativeCompilation, just as before. If possible, they should
be fixed and converted at a later date.
I have run a BUILD_COMPARE test on this change. It passes completely
clean on linux and solaris. On macosx, I get "binary" differences on
libosxkrb5, libjaas_unix and a handful of lauchers. I can't say why,
there's no change in symbols, deps, or disasm. On windows, I get a minor
disasm change in sawindbg.
Bug: https://bugs.openjdk.java.net/browse/JDK-8199639
WebRev:
http://cr.openjdk.java.net/~ihse/JDK-8199639-introduce-SetupJdkLibrary/webrev.01
/Magnus
More information about the build-dev
mailing list