RFR: JDK-8071469 Cleanup include and exclude of sound native libraries after source code restructure

Magnus Ihse Bursie magnus.ihse.bursie at oracle.com
Thu Mar 15 01:07:54 UTC 2018


 From the bug description:

Moving this to a separate bug from JDK-8055190. In SoundLibraries.gmk, 
the source code splitting is not complete. The directory libjsound is 
used to build not only libjsound but libjsoundalsa and libjsoundds, and 
thus needs a complex include/exclude system like before.

I have tested this using COMPARE_BUILD. Windows and solaris are 
completely clean. On macosx, there's a binary diff (but nothing else) on 
libjsound.dylib. On linux, some offset seems to have changed, which 
caused a slight change in disass and fulldump for libjsound.so. I'm not 
quite sure what's causing it, but I'm convinced it's harmless.

Bug: https://bugs.openjdk.java.net/browse/JDK-8071469
WebRev: 
http://cr.openjdk.java.net/~ihse/JDK-8071469-cleanup-sound-libs/webrev.01

/Magnus




More information about the build-dev mailing list